> On Nov. 17, 2017, 8:18 p.m., Sergey Shelukhin wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java > > Lines 517 (patched) > > <https://reviews.apache.org/r/63890/diff/2/?file=1896465#file1896465line524> > > > > this seems to get all triggers for the pools... I can file a follow-up > > jira, I think we need to make addition of triggers to Tez more explicit
Until we have explicit GLOBAL flag, this will get all triggers that is tied to default pool path. > On Nov. 17, 2017, 8:18 p.m., Sergey Shelukhin wrote: > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMFullResourcePlan.java > > Line 329 (original), 329 (patched) > > <https://reviews.apache.org/r/63890/diff/2/?file=1896470#file1896470line329> > > > > this looks like a change to generated code without a thrift change. The > > null check (or isSet check?) should be in the caller Oops. Didn't realize this is generated file. Moved it to caller. - Prasanth_J ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63890/#review191387 ----------------------------------------------------------- On Nov. 17, 2017, 2:20 a.m., Prasanth_J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63890/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2017, 2:20 a.m.) > > > Review request for hive and Sergey Shelukhin. > > > Bugs: HIVE-18025 > https://issues.apache.org/jira/browse/HIVE-18025 > > > Repository: hive-git > > > Description > ------- > > HIVE-18025: Push resource plan changes to tez/unmanaged sessions > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestTriggersNoTezSessionPool.java > bcce3dc > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestTriggersTezSessionPoolManager.java > b377275 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java e7af5e0 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java > 4e48f15 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolSession.java > 769b24a > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 3990f95 > > ql/src/java/org/apache/hadoop/hive/ql/wm/MetastoreGlobalTriggersFetcher.java > 87c007f > service/src/java/org/apache/hive/service/server/HiveServer2.java 5a6d0c8 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMFullResourcePlan.java > 1d21908 > > > Diff: https://reviews.apache.org/r/63890/diff/2/ > > > Testing > ------- > > > Thanks, > > Prasanth_J > >
