-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63864/#review191232
-----------------------------------------------------------




llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java
Lines 316 (patched)
<https://reviews.apache.org/r/63864/#comment268924>

    why would it stack overflow? I don't see a loop here.



llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java
Lines 168 (patched)
<https://reviews.apache.org/r/63864/#comment268925>

    nit: Map



llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java
Lines 414 (patched)
<https://reviews.apache.org/r/63864/#comment268928>

    or update log4j2 properties file with WARN default for WM_LOG logger.



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
Line 211 (original), 221 (patched)
<https://reviews.apache.org/r/63864/#comment268930>

    Will fix it in HIVE-18025


- Prasanth_J


On Nov. 16, 2017, 3:36 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63864/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2017, 3:36 a.m.)
> 
> 
> Review request for hive and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   
> llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java
>  a02a414a76 
>   
> llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java
>  9dc521e39e 
>   
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/GuaranteedTasksAllocator.java 
> a1775cd6bb 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java 
> 851245c154 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 
> 1fe5859490 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 
> 5ba6639e0c 
> 
> 
> Diff: https://reviews.apache.org/r/63864/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Reply via email to