> On Nov. 9, 2017, 1:08 a.m., Alexander Kolbasov wrote: > > With this change, do we still need Config stored in the HiveAlterHandle > > itself? What is the value of returning such config in getConf() Should the > > new HiveAlterHandle extend COnfigurable? Do we need setConf method?
AlterHandler is a public interface. Changing that to not extend Configurable is a significant change, arguable as backward incompatible. This is something that will result in cleaner code, but not necessarily needed for the bug to be fixed. So, I chose not to change AlterHandler. - Janaki ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63586/#review190522 ----------------------------------------------------------- On Nov. 8, 2017, 7:17 p.m., Janaki Lahorani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63586/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2017, 7:17 p.m.) > > > Review request for hive, Alexander Kolbasov, Andrew Sherman, Sahil Takiar, > and Vihang Karajgaonkar. > > > Repository: hive-git > > > Description > ------- > > HMS handler thread local will have the configuration changes from the user > local only to that connection. HiveAlterHandler should use the thread local > to pick up user's configuration changes. > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreAlterColumnPar.java > PRE-CREATION > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > 921cfc00343807179340fbdf40f21e2a46d936ab > > > Diff: https://reviews.apache.org/r/63586/diff/4/ > > > Testing > ------- > > > Thanks, > > Janaki Lahorani > >
