----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63346/#review190361 -----------------------------------------------------------
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java Lines 9471 (patched) <https://reviews.apache.org/r/63346/#comment267698> Atleast this should be documented in the config description. Launching 4 AMs and not using them is also wasteful. On poorly configured cluster this can have adverse effects (default AMs taking up space of LLAP daemons). IMHO for better OOTB experience making it configurable is better option. We can ship with default 4 but if someone thinks 4 is wasteful then they have option of using default pool and less resources. - Prasanth_J On Nov. 7, 2017, 3:09 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63346/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2017, 3:09 a.m.) > > > Review request for hive, Harish Jaiprakash and Prasanth_J. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 305e9dc2ed > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestTriggersWorkloadManager.java > 012361a186 > metastore/scripts/upgrade/derby/046-HIVE-17566.derby.sql f9b0765916 > metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 054978e3e4 > metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql c1578fcda9 > metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql a13d976e37 > metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 1ceb7239eb > metastore/scripts/upgrade/mysql/046-HIVE-17566.mysql.sql 03ee4cfd64 > metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 06648540f0 > metastore/scripts/upgrade/oracle/046-HIVE-17566.oracle.sql a13d976e37 > metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql a94985a63e > metastore/scripts/upgrade/postgres/045-HIVE-17566.postgres.sql e80e6124fc > metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql > be1bb1eee0 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 826ae565c1 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java a1b7cfb158 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java > 9954c249d4 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java > 169991c639 > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManagerFederation.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java > f1258bab17 > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java > 9df1b82d62 > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 3415a23dec > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 0263df0d04 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 8708f2a0b4 > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 69a1d63f93 > ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java > 04c9e4413d > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java > 0347e914bc > ql/src/test/queries/clientpositive/resourceplan.q f1be695cb8 > ql/src/test/results/clientpositive/llap/resourceplan.q.out 2f314a6a8d > service/src/java/org/apache/hive/service/server/HiveServer2.java 300ba7281d > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 7334a0c9fa > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > f8ebc124c4 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMPool.java > 0c1e7866c0 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMResourcePlan.java > 27a1bd8f25 > standalone-metastore/src/main/resources/package.jdo b271e026e9 > standalone-metastore/src/main/thrift/hive_metastore.thrift 9f92bf6be2 > > > Diff: https://reviews.apache.org/r/63346/diff/10/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
