[ 
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163523#comment-13163523
 ] 

jirapos...@reviews.apache.org commented on HIVE-2340:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2991/
-----------------------------------------------------------

(Updated 2011-12-06 11:02:00.777597)


Review request for hive and Carl Steinbach.


Changes
-------

I've overrode existing optimizer by mistake. Fixed it.


Summary
-------

Mostly copied from existing code. Not tested intensively yet, but it is seemed 
to be used frequently for us.


This addresses bug HIVE-2340.
    https://issues.apache.org/jira/browse/HIVE-2340


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ColumnPrunerProcFactory.java 
82a141d 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkDeDuplication.java 
e91b4d5 
  ql/src/test/queries/clientpositive/reduce_deduplicate_extended.q PRE-CREATION 
  ql/src/test/results/clientpositive/reduce_deduplicate_extended.q.out 
PRE-CREATION 

Diff: https://reviews.apache.org/r/2991/diff


Testing
-------

new test cases added : reduce_deduplicate_extended.q


Thanks,

Navis


                
> optimize orderby followed by a groupby
> --------------------------------------
>
>                 Key: HIVE-2340
>                 URL: https://issues.apache.org/jira/browse/HIVE-2340
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Query Processor
>            Reporter: Navis
>            Priority: Minor
>         Attachments: HIVE-2340.1.patch.txt
>
>
> Before implementing optimizer for JOIN-GBY, try to implement RS-GBY 
> optimizer(cluster-by following group-by).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to