----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63427/ -----------------------------------------------------------
(Updated Nov. 2, 2017, 8:40 p.m.) Review request for hive, Ashutosh Chauhan and Jason Dere. Summary (updated) ----------------- HIVE-17936 Repository: hive-git Description ------- Dynamic Semijoin Reduction : markSemiJoinForDPP marks unwanted semijoin branches In method markSemiJoinForDPP (HIVE-17399), the nDVs comparison should not have equality as there is a chance that the values are same on both sides and the branch is still marked as good when it shouldn't be. Add a configurable factor to see how useful this is if nDVs on smaller side are only slightly less than that on TS side. Diffs ----- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6631a6e45d ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java da30c3b642 ql/src/test/queries/clientpositive/dynamic_semijoin_reduction.q 6cc0a7f7a9 ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out 1a1a4d9b2d Diff: https://reviews.apache.org/r/63427/diff/2/ Testing ------- Thanks, Deepak Jaiswal
