----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63458/#review189929 -----------------------------------------------------------
service/src/java/org/apache/hive/service/cli/session/SessionManager.java Lines 477 (patched) <https://reviews.apache.org/r/63458/#comment267171> Can you also log the key on which limit has been reached ? (username and/or ipaddress). It would help with troubleshooting from the server logs. service/src/java/org/apache/hive/service/cli/session/SessionManager.java Lines 508 (patched) <https://reviews.apache.org/r/63458/#comment267174> safer to check - if( connectionCount >= limit ) - Thejas Nair On Nov. 2, 2017, 8:08 a.m., Prasanth_J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63458/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2017, 8:08 a.m.) > > > Review request for hive, Sergey Shelukhin and Thejas Nair. > > > Bugs: HIVE-16917 > https://issues.apache.org/jira/browse/HIVE-16917 > > > Repository: hive-git > > > Description > ------- > > HIVE-16917: HiveServer2 guard rails - Limit concurrent connections from user > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a3c853a > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > 9b2ae57 > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > 6354c8c > > service/src/test/org/apache/hive/service/cli/TestCLIServiceConnectionLimits.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/63458/diff/2/ > > > Testing > ------- > > > Thanks, > > Prasanth_J > >
