----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63381/#review189651 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java Line 315 (original), 326 (patched) <https://reviews.apache.org/r/63381/#comment266840> why does this only close pool sessions? the old behavior is to close all of them ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java Lines 431 (patched) <https://reviews.apache.org/r/63381/#comment266841> hmm... why is this assumed to be a non-pool session? I think canWork... may return true for pool sessions, in fact I'd expect it to be a common path where user doesn;t have any special configs or queue requests. IIRC this might be the reuse use case. ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java Lines 168 (patched) <https://reviews.apache.org/r/63381/#comment266843> hmm... where is this conf coming from? is it possible to initialize it with the main conf when HS2 is being initialized, since it only applies in HS2? This looks like it may initialize with some random user task conf and also may not be threadsafe - Sergey Shelukhin On Oct. 27, 2017, 11:08 p.m., Prasanth_J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63381/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2017, 11:08 p.m.) > > > Review request for hive and Sergey Shelukhin. > > > Bugs: HIVE-17926 > https://issues.apache.org/jira/browse/HIVE-17926 > > > Repository: hive-git > > > Description > ------- > > HIVE-17926: Support triggers for non-pool sessions > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestTriggersNoTezSessionPool.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java > b67c933b192c445ef6084d30b6398444d510d953 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java > 9b4714f1d79d0016e2460386cc38b3f2a162ae0b > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java > a1b7cfb15803074e2b19236da03790a189f17ff2 > > > Diff: https://reviews.apache.org/r/63381/diff/1/ > > > Testing > ------- > > > Thanks, > > Prasanth_J > >
