----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62309/#review185348 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java Line 355 (original), 357 (patched) <https://reviews.apache.org/r/62309/#comment261653> This comment can be deleted. ql/src/test/results/clientpositive/filter_cardinality.q.out Lines 1 (patched) <https://reviews.apache.org/r/62309/#comment261651> No need for new tests. Plenty of coverage in existing tests. ql/src/test/results/clientpositive/join47.q.out Line 363 (original), 363 (patched) <https://reviews.apache.org/r/62309/#comment261649> Is this expected? Seems like patch handled expressions only in Filter not in Join. Also, new estimates are suspiciously too low. ql/src/test/results/clientpositive/join47.q.out Line 562 (original), 562 (patched) <https://reviews.apache.org/r/62309/#comment261650> Expected ? - Ashutosh Chauhan On Sept. 13, 2017, 10:14 p.m., Vineet Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62309/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2017, 10:14 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-17465 > https://issues.apache.org/jira/browse/HIVE-17465 > > > Repository: hive-git > > > Description > ------- > > This patch fixes estimation of cardinality for filter with AND predicates. > > > Diffs > ----- > > data/files/filterCard.txt PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java > 423913b56b > ql/src/test/queries/clientpositive/filter_cardinality.q PRE-CREATION > ql/src/test/results/clientpositive/annotate_stats_deep_filters.q.out > 6e2975e671 > ql/src/test/results/clientpositive/annotate_stats_join_pkfk.q.out > e04c1c6bc5 > ql/src/test/results/clientpositive/filter_cardinality.q.out PRE-CREATION > ql/src/test/results/clientpositive/join47.q.out 20dce5d3bb > ql/src/test/results/clientpositive/llap/explainuser_1.q.out 48c02a24ad > ql/src/test/results/clientpositive/llap/vector_decimal_cast.q.out > c45210e562 > ql/src/test/results/clientpositive/llap/vector_if_expr.q.out 32d100180d > ql/src/test/results/clientpositive/llap/vectorization_0.q.out db76eaaf1b > ql/src/test/results/clientpositive/llap/vectorization_10.q.out f06c2dbcc6 > ql/src/test/results/clientpositive/llap/vectorization_17.q.out 1c07962d83 > ql/src/test/results/clientpositive/llap/vectorization_7.q.out 6c32ccf42d > ql/src/test/results/clientpositive/llap/vectorization_short_regress.q.out > 66764cf42b > ql/src/test/results/clientpositive/llap/vectorized_nested_mapjoin.q.out > 2a95065203 > ql/src/test/results/clientpositive/mapjoin47.q.out 2904b68813 > ql/src/test/results/clientpositive/perf/query23.q.out dde707d0ea > ql/src/test/results/clientpositive/smb_mapjoin_47.q.out 074600ef02 > ql/src/test/results/clientpositive/spark/vectorization_10.q.out 1f953575e3 > ql/src/test/results/clientpositive/spark/vectorization_12.q.out 4e26314499 > ql/src/test/results/clientpositive/spark/vectorization_17.q.out b43c506c6f > ql/src/test/results/clientpositive/vectorization_10.q.out d2d9bf644b > ql/src/test/results/clientpositive/vectorization_12.q.out 63ea984a33 > ql/src/test/results/clientpositive/vectorization_17.q.out c0186082df > ql/src/test/results/clientpositive/vectorization_7.q.out 218d307915 > > > Diff: https://reviews.apache.org/r/62309/diff/1/ > > > Testing > ------- > > * Added new tests > * Updated existing tests > > > Thanks, > > Vineet Garg > >
