> On Sept. 7, 2017, 4:37 p.m., Gunther Hagleitner wrote: > > llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java > > Lines 550 (patched) > > <https://reviews.apache.org/r/62108/diff/2/?file=1816630#file1816630line560> > > > > dummy impl v boolean everywhere?
Doing the checks is more straightforward and semantically obvious. > On Sept. 7, 2017, 4:37 p.m., Gunther Hagleitner wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java > > Lines 118 (patched) > > <https://reviews.apache.org/r/62108/diff/2/?file=1816634#file1816634line118> > > > > shouldn't this be settable thru config then? It is already settable by specifying registry name. This is an additional flag; when one HS2 hosts both types of sessions, only some would use the registry for now. > On Sept. 7, 2017, 4:37 p.m., Gunther Hagleitner wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java > > Line 155 (original), 157 (patched) > > <https://reviews.apache.org/r/62108/diff/2/?file=1816634#file1816634line157> > > > > are you introducing a new copy of the conf here? why? So that each session has its own conf, the initConf is cloned. Previously it was done somewhere else. - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62108/#review184833 ----------------------------------------------------------- On Sept. 6, 2017, 8:25 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62108/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2017, 8:25 p.m.) > > > Review request for hive and Gunther Hagleitner. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java cf3f50ba64 > > llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapZookeeperRegistryImpl.java > 65f8f945aa > > llap-client/src/java/org/apache/hadoop/hive/registry/impl/TezAmInstance.java > PRE-CREATION > > llap-client/src/java/org/apache/hadoop/hive/registry/impl/TezAmRegistryImpl.java > PRE-CREATION > > llap-client/src/java/org/apache/hadoop/hive/registry/impl/ZkRegistryBase.java > c7737706c6 > > llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java > cf8bd469dc > > llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/endpoint/LlapPluginServerImpl.java > f3c0d5213f > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/SessionExpirationTracker.java > 8bee77ea72 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java > 4f58565a4c > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java > 1f4705c083 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolSession.java > 005eeedc02 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java > fe5c6a1e45 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java f1f10286a3 > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java d7592bb966 > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/SampleTezSessionState.java > 973c0cc630 > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java > d2b98c46ca > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezTask.java 176692b6e5 > > > Diff: https://reviews.apache.org/r/62108/diff/2/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
