----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60085/#review183060 -----------------------------------------------------------
Thanks Zsombor, just two more comments: - There is an example for the cloudhost.properties file on hive/testutils/ptest2/conf/cloudhost.properties.example. Can we provide an example for the server properties as well? - How is the ptest server configured to pass the server properties? I'm trying to figure it out from the code (I see that using command line parameters and another place as an environment variable). Could you give an example? - Sergio Pena On Aug. 8, 2017, 12:50 p.m., Barna Zsombor Klara wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60085/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2017, 12:50 p.m.) > > > Review request for hive, Marta Kuczora, Peter Vary, and Sergio Pena. > > > Bugs: HIVE-14747 > https://issues.apache.org/jira/browse/HIVE-14747 > > > Repository: hive-git > > > Description > ------- > > HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client > > > Diffs > ----- > > > testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/ExecutionController.java > 2f96ad03023e9f51d44d203f34edd04183605a22 > > testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java > b2c61f03c5bf5f170894141848c89fc26129115a > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java > 1cdfdb309acd8282e593abd7ed10c87721926c60 > > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/Context.java > 14984bafdd18fb7636e729cc7fbbfa349b0f043e > > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/ExecutionContextConfiguration.java > 35ddd44accf34be1f5957c6df31802ee8c8022b5 > > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestConfiguration.java > e584f9c105fa134e3e267d6c6817d441b4c6b249 > > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestParser.java > a243774e52f3f5fda4a082bb99387cf5808c307b > > testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestJIRAService.java > b97b890dfe855539de2696788327ba9b4a841ff3 > > testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestContext.java > PRE-CREATION > > testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestConfiguration.java > 848faf27af1ed8945d7013b6562bab544605e4bc > > > Diff: https://reviews.apache.org/r/60085/diff/5/ > > > Testing > ------- > > Added unit tests for the Context class. > > > Thanks, > > Barna Zsombor Klara > >