> On July 28, 2017, 7:01 p.m., Sahil Takiar wrote: > > Overall it looks good. What about other Maven options though? Would it be > > difficult to update this patch so that any option for `mvn` can be passed > > in? Not just options specified by `-D`?
Sorry for the very late reply Sahil. I'm not sure how useful it would be to propagate any/other maven args, I can't think of a use case where we would want a specific maven arg on a per test profile or per test branch basis. And if one day we decide to globally change something, e.g. to increase the memory needed or the thread number, then we only need to edit one vm template in PTest. I guess that would not be a significantly bigger effort than to edit the shell script kicking off the PTest execution. But if you can share a more useful usecase, then of course I'd be happy to update the patch. - Barna Zsombor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59402/#review181710 ----------------------------------------------------------- On May 19, 2017, 3:10 p.m., Barna Zsombor Klara wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59402/ > ----------------------------------------------------------- > > (Updated May 19, 2017, 3:10 p.m.) > > > Review request for hive, Sergio Pena and Sahil Takiar. > > > Bugs: HIVE-16718 > https://issues.apache.org/jira/browse/HIVE-16718 > > > Repository: hive-git > > > Description > ------- > > HIVE-16718: Provide a way to pass in user supplied maven build and test > arguments to Ptest > > > Diffs > ----- > > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java > 1cdfdb309acd8282e593abd7ed10c87721926c60 > > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestConfiguration.java > e584f9c105fa134e3e267d6c6817d441b4c6b249 > > > Diff: https://reviews.apache.org/r/59402/diff/1/ > > > Testing > ------- > > Tested manually that I can pass in 0, 1 or 2 arguments to both mvnBuildArgs > and mvnTestArgs in PTest. > Arguments will be key value pairs separated by '='. The '-D' will be added > automatically. > > > Thanks, > > Barna Zsombor Klara > >
