-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61625/#review183018
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdSelectivity.java
Line 124 (original), 116 (patched)
<https://reviews.apache.org/r/61625/#comment259007>

    better name: ndvEstimate?



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdSelectivity.java
Lines 187 (patched)
<https://reviews.apache.org/r/61625/#comment259006>

    comment: max ndv across all column references from both sides of table.


- Ashutosh Chauhan


On Aug. 15, 2017, 1:20 a.m., Vineet Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61625/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2017, 1:20 a.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and Jesús Camacho Rodríguez.
> 
> 
> Bugs: HIVE-17308
>     https://issues.apache.org/jira/browse/HIVE-17308
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> See JIRA description
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 056f2d7834 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveConfPlannerContext.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HivePlannerContext.java
>  bdf995548f 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdSelectivity.java
>  046f51b5a0 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java d6695ccbf2 
>   
> ql/src/test/org/apache/hadoop/hive/ql/optimizer/calcite/TestCBORuleFiredOnlyOnce.java
>  884e034731 
>   ql/src/test/results/clientpositive/annotate_stats_join.q.out d24324a175 
>   ql/src/test/results/clientpositive/join_alt_syntax.q.out 1c08e6a630 
>   ql/src/test/results/clientpositive/join_cond_pushdown_2.q.out 6b03800d4a 
>   ql/src/test/results/clientpositive/join_cond_pushdown_4.q.out 1408dad546 
>   ql/src/test/results/clientpositive/llap/correlationoptimizer1.q.out 
> 1e4e08453b 
>   ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out 
> 478b0828a3 
>   ql/src/test/results/clientpositive/llap/dynamic_semijoin_user_level.q.out 
> a73faebcb7 
>   ql/src/test/results/clientpositive/llap/explainuser_1.q.out b36fe2a83f 
>   ql/src/test/results/clientpositive/llap/explainuser_2.q.out 4f1a4a1f14 
>   ql/src/test/results/clientpositive/llap/join_max_hashtable.q.out 6520fd3f2b 
>   ql/src/test/results/clientpositive/llap/skewjoin.q.out f4fc43edfa 
>   ql/src/test/results/clientpositive/llap/subquery_exists.q.out 4d223923a7 
>   ql/src/test/results/clientpositive/llap/subquery_in.q.out df92bb2b93 
>   ql/src/test/results/clientpositive/llap/subquery_multi.q.out 5673f0ee8c 
>   ql/src/test/results/clientpositive/llap/subquery_notin.q.out 3c6e95ae70 
>   ql/src/test/results/clientpositive/llap/subquery_scalar.q.out 05d4fc8093 
>   ql/src/test/results/clientpositive/llap/subquery_select.q.out 013b0a3bdd 
>   ql/src/test/results/clientpositive/llap/subquery_views.q.out 094d6b29b5 
>   ql/src/test/results/clientpositive/perf/query17.q.out 6c9e00bb6a 
>   ql/src/test/results/clientpositive/perf/query24.q.out 3eb65b67c6 
>   ql/src/test/results/clientpositive/perf/query25.q.out ee94eecc2c 
>   ql/src/test/results/clientpositive/perf/query29.q.out b3b9c3ed53 
>   ql/src/test/results/clientpositive/perf/query50.q.out 68d6611b43 
>   ql/src/test/results/clientpositive/perf/query54.q.out b9d0b8b376 
>   ql/src/test/results/clientpositive/perf/query64.q.out 7464430c03 
>   ql/src/test/results/clientpositive/perf/query72.q.out 4d18fb3a4f 
>   ql/src/test/results/clientpositive/perf/query85.q.out f188fa2b2c 
>   ql/src/test/results/clientpositive/spark/annotate_stats_join.q.out 
> cd24cbb6df 
>   ql/src/test/results/clientpositive/spark/join_alt_syntax.q.out f1728ce1f7 
>   ql/src/test/results/clientpositive/spark/join_cond_pushdown_2.q.out 
> c3b805aeb0 
>   ql/src/test/results/clientpositive/spark/join_cond_pushdown_4.q.out 
> 9c3aed8932 
> 
> 
> Diff: https://reviews.apache.org/r/61625/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>

Reply via email to