----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61380/#review182090 -----------------------------------------------------------
Thanks for the patch Zsombor! Just a minor comment and a question. Thanks, Peter beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java Lines 80 (patched) <https://reviews.apache.org/r/61380/#comment257956> Please add this the new parameter to the help text too: BeeLine.properties cmd-usage beeline/src/java/org/apache/hive/beeline/Rows.java Lines 164 (patched) <https://reviews.apache.org/r/61380/#comment257957> Why not calling the same o.toString() as before? - Peter Vary On Aug. 2, 2017, 3:56 p.m., Barna Zsombor Klara wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61380/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2017, 3:56 p.m.) > > > Review request for hive, Marta Kuczora and Peter Vary. > > > Bugs: HIVE-14786 > https://issues.apache.org/jira/browse/HIVE-14786 > > > Repository: hive-git > > > Description > ------- > > HIVE-14786: Beeline displays binary column data as string instead of byte > array > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java > 3ebbc9af9ba1a99dfc1d0af63ba362bae5eb2df4 > beeline/src/java/org/apache/hive/beeline/Rows.java > 924b9519a64427936101a9dc4bbe1831719194e6 > > beeline/src/test/org/apache/hive/beeline/TestIncrementalRowsWithNormalization.java > 68da841f850d2e97bf4b89071ec6d20ce8cf5d10 > > > Diff: https://reviews.apache.org/r/61380/diff/1/ > > > Testing > ------- > > > Thanks, > > Barna Zsombor Klara > >
