> On 六月 7, 2017, 8:45 p.m., Anthony Hsu wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Line 302 (original), 304 (patched) > > <https://reviews.apache.org/r/59885/diff/1/?file=1743915#file1743915line304> > > > > Do we need to close the PersistenceManager as well? > > Sunitha Beeram wrote: > Good point, but the call to shutdown() on line 301 closes pm.
Ah, yes, thanks for pointing that out. - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59885/#review177222 ----------------------------------------------------------- On 六月 7, 2017, 4:29 p.m., Sunitha Beeram wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59885/ > ----------------------------------------------------------- > > (Updated 六月 7, 2017, 4:29 p.m.) > > > Review request for hive, Carl Steinbach, Anthony Hsu, and Ratandeep Ratti. > > > Bugs: HIVE-16844 > https://issues.apache.org/jira/browse/HIVE-16844 > > > Repository: hive-git > > > Description > ------- > > HIVE-16844: Fix Connection leak in ObjectStore when new Conf object is used > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 4676e15942d72b0db56bedf0ff30aa60964c28d8 > > > Diff: https://reviews.apache.org/r/59885/diff/1/ > > > Testing > ------- > > Can't provide unit tests to test the functionality, but problem is > reproducible and one way to simulate it is by setting pmf=null in > ObjectStore::setConf - you will notice leaked connections. With the fix the > same does not happen. > > > Thanks, > > Sunitha Beeram > >
