[ 
https://issues.apache.org/jira/browse/HIVE-2611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159034#comment-13159034
 ] 

jirapos...@reviews.apache.org commented on HIVE-2611:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2953/
-----------------------------------------------------------

Review request for hive, Yongqiang He and namit jain.


Summary
-------

If an index is table based, when an index is created it creates a table for 
that index.  We should log that table as the output of an index creation 
command.


This addresses bug HIVE-2611.
    https://issues.apache.org/jira/browse/HIVE-2611


Diffs
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1207723 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
1207723 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java 1207723 
  
trunk/ql/src/test/results/clientnegative/alter_concatenate_indexed_table.q.out 
1207723 
  trunk/ql/src/test/results/clientnegative/index_bitmap_no_map_aggr.q.out 
1207723 
  trunk/ql/src/test/results/clientnegative/index_compact_entry_limit.q.out 
1207723 
  trunk/ql/src/test/results/clientnegative/index_compact_size_limit.q.out 
1207723 
  trunk/ql/src/test/results/clientnegative/merge_negative_1.q.out 1207723 
  
trunk/ql/src/test/results/clientpositive/alter_concatenate_indexed_table.q.out 
1207723 
  trunk/ql/src/test/results/clientpositive/alter_index.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_auth.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_auto.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_auto_empty.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_auto_file_format.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_auto_mult_tables.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_auto_mult_tables_compact.q.out 
1207723 
  trunk/ql/src/test/results/clientpositive/index_auto_multiple.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_auto_partitioned.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_auto_self_join.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_auto_unused.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_auto_update.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_bitmap.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_bitmap1.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_bitmap2.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_bitmap3.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_bitmap_auto.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_bitmap_auto_partitioned.q.out 
1207723 
  trunk/ql/src/test/results/clientpositive/index_bitmap_compression.q.out 
1207723 
  trunk/ql/src/test/results/clientpositive/index_bitmap_rc.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_compact.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_compact_1.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_compact_2.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_compact_3.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_compact_binary_search.q.out 
1207723 
  trunk/ql/src/test/results/clientpositive/index_compression.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_creation.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_stale.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_stale_partitioned.q.out 
1207723 
  trunk/ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/show_indexes_edge_cases.q.out 
1207723 
  trunk/ql/src/test/results/clientpositive/show_indexes_syntax.q.out 1207723 

Diff: https://reviews.apache.org/r/2953/diff


Testing
-------

Verified that the output of a create index command is now the index table.

Ran the unit tests.


Thanks,

Kevin


                
> Make index table output of create index command if index is table based
> -----------------------------------------------------------------------
>
>                 Key: HIVE-2611
>                 URL: https://issues.apache.org/jira/browse/HIVE-2611
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-2611.1.patch.txt
>
>
> If an index is table based, when that index is created a table is created to 
> contain that index.  This should be listed in the output of the command.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to