> On June 6, 2017, 6:02 p.m., Jason Dere wrote: > > ql/src/test/results/clientpositive/llap/semijoin_hint.q.out > > Line 1406 (original), 1401 (patched) > > <https://reviews.apache.org/r/59726/diff/2/?file=1741963#file1741963line1406> > > > > In the updated plan, there are no semijoin reduction optimizations.
Thanks for finding this out. The hint had parameters in incorrect order causing it to miss. Fix is coming in shortly. - Deepak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59726/#review177063 ----------------------------------------------------------- On June 6, 2017, 12:54 a.m., Deepak Jaiswal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59726/ > ----------------------------------------------------------- > > (Updated June 6, 2017, 12:54 a.m.) > > > Review request for hive and Jason Dere. > > > Bugs: HIVE-16804 > https://issues.apache.org/jira/browse/HIVE-16804 > > > Repository: hive-git > > > Description > ------- > > Currently the semijoin hint takes source table input. However, to provide > better control, also provide the target table name in hint. > The Target field is added as a mandatory parameter. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/DynamicPartitionPruningOptimization.java > 8a62982e1e > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > d514644da0 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemiJoinHint.java f7fd306a2c > ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java 7e156f610a > ql/src/test/queries/clientpositive/semijoin_hint.q 71fa445ec8 > ql/src/test/results/clientpositive/llap/semijoin_hint.q.out ae9bf9bd8b > > > Diff: https://reviews.apache.org/r/59726/diff/2/ > > > Testing > ------- > > > Thanks, > > Deepak Jaiswal > >
