----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59624/#review176333 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveAlgorithmsUtil.java Line 64 (original), 64 (patched) <https://reviews.apache.org/r/59624/#comment249733> Should this instead be mq.getRowCount(hr); That is waht javadoc of RelNode::estimateRowCount() is suggesting? ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveOnTezCostModel.java Line 82 (original), 82 (patched) <https://reviews.apache.org/r/59624/#comment249734> Should this instead be mq.getRowCount(ts); That is waht javadoc of RelNode::estimateRowCount() is suggesting? ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/FilterSelectivityEstimator.java Line 94 (original), 96 (patched) <https://reviews.apache.org/r/59624/#comment249735> Should this instead be mq.getRowCount(childRel); That is waht javadoc of RelNode::estimateRowCount() is suggesting? ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdRowCount.java Line 75 (original), 75 (patched) <https://reviews.apache.org/r/59624/#comment249736> Should this instead be mq.getRowCount(join); That is waht javadoc of RelNode::estimateRowCount() is suggesting? - Ashutosh Chauhan On May 29, 2017, 7:54 a.m., Remus Rusanu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59624/ > ----------------------------------------------------------- > > (Updated May 29, 2017, 7:54 a.m.) > > > Review request for hive, Ashutosh Chauhan and Jesús Camacho Rodríguez. > > > Repository: hive-git > > > Description > ------- > > HIVE-16757 remove use of deperecated RelNode.getRows(), use > estimateRowCount(mq) instead > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveAlgorithmsUtil.java > 4ba10e2 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveCostModel.java > 4af1f8d > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveDefaultCostModel.java > 40f2cef > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveOnTezCostModel.java > af5fc5e > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveRelMdCost.java > cbea307 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/FilterSelectivityEstimator.java > a25b58b > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdDistinctRowCount.java > 77f7aa8 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdRowCount.java > 7bba80b > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdSelectivity.java > 7192684 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdUniqueKeys.java > 9a5a2ba > > > Diff: https://reviews.apache.org/r/59624/diff/1/ > > > Testing > ------- > > > Thanks, > > Remus Rusanu > >
