----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59468/#review176243 -----------------------------------------------------------
ql/src/test/queries/clientpositive/count_dist_rewrite.q Lines 63-65 (patched) <https://reviews.apache.org/r/59468/#comment249600> As mentioned previously, lets delete these tests. ql/src/test/results/clientpositive/perf/query16.q.out Lines 3-5 (original), 3-5 (patched) <https://reviews.apache.org/r/59468/#comment249601> Optimization shouldn't have fired in this case. Aggregations are on different columns. ql/src/test/results/clientpositive/perf/query16.q.out Line 93 (original), 100 (patched) <https://reviews.apache.org/r/59468/#comment249602> Optimization shouldn't have fired in this case. Aggregations are on different columns. ql/src/test/results/clientpositive/perf/query94.q.out Line 1 (original), 1 (patched) <https://reviews.apache.org/r/59468/#comment249603> Optimization shouldn't have fired in this case. Aggregations are on columns different than keys. ql/src/test/results/clientpositive/perf/query94.q.out Line 29 (original), 36 (patched) <https://reviews.apache.org/r/59468/#comment249604> Optimization shouldn't have fired in this case. Aggregations are on columns different than keys. ql/src/test/results/clientpositive/perf/query95.q.out Line 1 (original), 1 (patched) <https://reviews.apache.org/r/59468/#comment249605> Optimization shouldn't have fired in this case. Aggregations are on columns different than keys. - Ashutosh Chauhan On May 27, 2017, 2:20 a.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59468/ > ----------------------------------------------------------- > > (Updated May 27, 2017, 2:20 a.m.) > > > Review request for hive, Ashutosh Chauhan and Gopal V. > > > Repository: hive-git > > > Description > ------- > > HIVE-16654 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2dfc8b6f89 > itests/src/test/resources/testconfiguration.properties 47a13c93b9 > ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 8b04cd44fa > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/CountDistinctRewriteProc.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 7dace9076f > ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java 38a9ef2af1 > ql/src/test/queries/clientpositive/count_dist_rewrite.q PRE-CREATION > ql/src/test/results/clientpositive/count_dist_rewrite.q.out PRE-CREATION > ql/src/test/results/clientpositive/groupby_sort_11.q.out 2b3bf4a07a > ql/src/test/results/clientpositive/llap/count_dist_rewrite.q.out > PRE-CREATION > ql/src/test/results/clientpositive/nullgroup4.q.out e5a8eeee14 > ql/src/test/results/clientpositive/perf/query16.q.out cf90c0c162 > ql/src/test/results/clientpositive/perf/query28.q.out 78129cf68b > ql/src/test/results/clientpositive/perf/query94.q.out 836b16bf9f > ql/src/test/results/clientpositive/perf/query95.q.out fa94d0842b > ql/src/test/results/clientpositive/udf_count.q.out f60ad0485e > > > Diff: https://reviews.apache.org/r/59468/diff/3/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
