> On May 22, 2017, 8:30 p.m., Sahil Takiar wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreSchemaInfo.java > > Lines 27 (patched) > > <https://reviews.apache.org/r/59429/diff/2/?file=1726935#file1726935line27> > > > > Can you add javadocs for the rest of these methods. > > > > Since this is an interface can you all add target audience annotations.
+1 > On May 22, 2017, 8:30 p.m., Sahil Takiar wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfoFactory.java > > Lines 59 (patched) > > <https://reviews.apache.org/r/59429/diff/2/?file=1726937#file1726937line59> > > > > Should also document that this constructor is necessary good point. Can we add a testcase to ensure that the class has such constructor? - Naveen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59429/#review175690 ----------------------------------------------------------- On May 22, 2017, 4:03 p.m., Vihang Karajgaonkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59429/ > ----------------------------------------------------------- > > (Updated May 22, 2017, 4:03 p.m.) > > > Review request for hive, Naveen Gangam, Sergio Pena, and Sahil Takiar. > > > Bugs: HIVE-16723 > https://issues.apache.org/jira/browse/HIVE-16723 > > > Repository: hive-git > > > Description > ------- > > HIVE-16723 : Enable configurable MetaStoreSchemaInfo > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java > a45358077a07f09f07dd14eb028fb54b812e8a69 > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > 1c37b6e091cb02f5bf1a6a795712807b50d61424 > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetastoreVersion.java > 7188af62acb3cb0305e2cdaf9727576d61418013 > itests/hive-unit/src/test/java/org/apache/hive/beeline/TestSchemaTool.java > 438a7d6dc86cb291d7d0a9b4501a9df07f1934d7 > > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreSchemaInfo.java > PRE-CREATION > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java > 320902bed5fc49323d2b372354fe28d38358459e > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfoFactory.java > PRE-CREATION > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > b28983f7a9e36832d643c8a2293e19665dd79528 > > metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreSchemaFactory.java > PRE-CREATION > > metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreSchemaInfo.java > 71420012756ca26bf399228efdf011597eb70b17 > > > Diff: https://reviews.apache.org/r/59429/diff/2/ > > > Testing > ------- > > > Thanks, > > Vihang Karajgaonkar > >
