> On May 17, 2017, 2:46 a.m., Jason Dere wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryTracker.java > > Lines 490 (patched) > > <https://reviews.apache.org/r/59325/diff/1/?file=1722071#file1722071line509> > > > > Does the size() check need to happen within the lock - what if size() > > == 0, but a new fragment is added while we try to get the dagLock?
I don't think it makes a difference. Will move the check into the writeLock to be safe. - Siddharth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59325/#review175192 ----------------------------------------------------------- On May 17, 2017, 12:30 a.m., Siddharth Seth wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59325/ > ----------------------------------------------------------- > > (Updated May 17, 2017, 12:30 a.m.) > > > Review request for hive, Jason Dere and Sergey Shelukhin. > > > Bugs: HIVE-14052 > https://issues.apache.org/jira/browse/HIVE-14052 > > > Repository: hive-git > > > Description > ------- > > Cleanup of structures required when LLAP access from external clients > completes > > > Diffs > ----- > > > llap-common/src/gen/protobuf/gen-java/org/apache/hadoop/hive/llap/daemon/rpc/LlapDaemonProtocolProtos.java > ece31ed > llap-common/src/protobuf/LlapDaemonProtocol.proto 3a3a2b8 > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryInfo.java > ce2f457 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryTracker.java > daeb555 > > llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorTestHelpers.java > 27c426c > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java > 868eec7 > > > Diff: https://reviews.apache.org/r/59325/diff/1/ > > > Testing > ------- > > > Thanks, > > Siddharth Seth > >
