----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58935/#review175292 -----------------------------------------------------------
Looks good. common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java Line 286 (original), 289 (patched) <https://reviews.apache.org/r/58935/#comment248749> Need to update function name? Not limited to basic stats, nor to table (called for partitions as well.) - Ashutosh Chauhan On May 2, 2017, 10:04 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58935/ > ----------------------------------------------------------- > > (Updated May 2, 2017, 10:04 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > HIVE-16566 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java > a9e17c240d > hbase-handler/src/test/results/positive/external_table_ppd.q.out f09b880c06 > hbase-handler/src/test/results/positive/hbase_binary_storage_queries.q.out > 3d3e82d5da > hbase-handler/src/test/results/positive/hbasestats.q.out bf902e49b5 > > itests/hive-blobstore/src/test/results/clientpositive/write_final_output_blobstore.q.out > 8a90a9edc1 > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java > d67e03f3f5 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 757b7fc0ea > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java dec73a783f > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 0cf92052bc > ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 4f614a899b > ql/src/test/queries/clientpositive/alterColumnStats.q PRE-CREATION > ql/src/test/queries/clientpositive/alterColumnStatsPart.q PRE-CREATION > ql/src/test/results/clientnegative/alter_file_format.q.out e3f3b4cc62 > ql/src/test/results/clientnegative/unset_table_property.q.out 4aedfc5803 > ql/src/test/results/clientpositive/alterColumnStats.q.out PRE-CREATION > ql/src/test/results/clientpositive/alterColumnStatsPart.q.out PRE-CREATION > ql/src/test/results/clientpositive/alter_file_format.q.out ca569be13f > ql/src/test/results/clientpositive/alter_partition_clusterby_sortby.q.out > 8bd952514d > ql/src/test/results/clientpositive/alter_skewed_table.q.out fefef4c3a3 > ql/src/test/results/clientpositive/alter_table_add_partition.q.out > ae6624f6de > ql/src/test/results/clientpositive/alter_table_not_sorted.q.out 5afb7fadee > ql/src/test/results/clientpositive/autoColumnStats_3.q.out b916eba9fc > ql/src/test/results/clientpositive/autoColumnStats_4.q.out 101cc63ed8 > ql/src/test/results/clientpositive/binary_output_format.q.out 96afeb679a > ql/src/test/results/clientpositive/bucket1.q.out 78571aa765 > ql/src/test/results/clientpositive/bucket2.q.out a8e9f900a9 > ql/src/test/results/clientpositive/bucket_map_join_spark1.q.out 5478f1218c > ql/src/test/results/clientpositive/bucket_map_join_spark2.q.out e335683604 > ql/src/test/results/clientpositive/bucket_map_join_spark3.q.out bd5a438917 > ql/src/test/results/clientpositive/bucketmapjoin5.q.out febc2b62b5 > ql/src/test/results/clientpositive/bucketmapjoin_negative.q.out ee075c170f > ql/src/test/results/clientpositive/bucketmapjoin_negative2.q.out 2728bb7afb > > ql/src/test/results/clientpositive/column_names_with_leading_and_trailing_spaces.q.out > bc9258f11f > ql/src/test/results/clientpositive/compustat_avro.q.out 016b8e784d > ql/src/test/results/clientpositive/create_alter_list_bucketing_table1.q.out > 7d8e5c1353 > ql/src/test/results/clientpositive/create_like.q.out ff2e752a95 > ql/src/test/results/clientpositive/create_like2.q.out 38bd499d28 > ql/src/test/results/clientpositive/create_like_tbl_props.q.out 19459fbcd1 > ql/src/test/results/clientpositive/create_like_view.q.out 1e84b461b7 > ql/src/test/results/clientpositive/create_skewed_table1.q.out e4080b0750 > ql/src/test/results/clientpositive/create_table_like_stats.q.out f5ec72c030 > ql/src/test/results/clientpositive/create_with_constraints.q.out 64c3ec6c68 > ql/src/test/results/clientpositive/database_location.q.out 926db3a490 > ql/src/test/results/clientpositive/default_file_format.q.out ef0ca52dd2 > ql/src/test/results/clientpositive/describe_comment_indent.q.out 7b109b3026 > ql/src/test/results/clientpositive/describe_comment_nonascii.q.out > 70f234e7e1 > > ql/src/test/results/clientpositive/describe_formatted_view_partitioned.q.out > c55239b322 > ql/src/test/results/clientpositive/describe_syntax.q.out fe05b903d3 > ql/src/test/results/clientpositive/describe_table.q.out 93b2030839 > ql/src/test/results/clientpositive/display_colstats_tbllvl.q.out 7b49e4adc0 > ql/src/test/results/clientpositive/druid_basic1.q.out c16f81e798 > ql/src/test/results/clientpositive/druid_basic2.q.out 6177d56987 > ql/src/test/results/clientpositive/druid_intervals.q.out db8633e818 > ql/src/test/results/clientpositive/druid_timeseries.q.out ef3f8dd9ac > ql/src/test/results/clientpositive/druid_topn.q.out 323eda237d > ql/src/test/results/clientpositive/groupby_map_ppr.q.out 9be41df8a7 > ql/src/test/results/clientpositive/groupby_map_ppr_multi_distinct.q.out > 606ab4ed0e > ql/src/test/results/clientpositive/groupby_ppr.q.out 8a75c2e44f > ql/src/test/results/clientpositive/groupby_ppr_multi_distinct.q.out > 68d91eb8c1 > ql/src/test/results/clientpositive/groupby_sort_1_23.q.out 92babd79df > ql/src/test/results/clientpositive/groupby_sort_6.q.out 80baa664e3 > ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out 6e09753d6f > ql/src/test/results/clientpositive/input_part1.q.out 2f6f3024b9 > ql/src/test/results/clientpositive/input_part2.q.out 95f36ab613 > > ql/src/test/results/clientpositive/insert_values_orig_table_use_metadata.q.out > fa8417b31d > ql/src/test/results/clientpositive/join17.q.out 8bd67eb9dc > ql/src/test/results/clientpositive/join26.q.out 5bc8245079 > ql/src/test/results/clientpositive/join32.q.out 0358968b0e > ql/src/test/results/clientpositive/join33.q.out 0358968b0e > ql/src/test/results/clientpositive/join34.q.out 117afaced3 > ql/src/test/results/clientpositive/join35.q.out 1f90df94b8 > ql/src/test/results/clientpositive/join9.q.out befc47a7ef > ql/src/test/results/clientpositive/join_map_ppr.q.out dba176d52b > ql/src/test/results/clientpositive/list_bucket_dml_14.q.out ab30b7d8a4 > ql/src/test/results/clientpositive/llap/autoColumnStats_2.q.out e5e26ec9c7 > ql/src/test/results/clientpositive/llap/bucket2.q.out be886b0286 > ql/src/test/results/clientpositive/llap/bucket4.q.out b4f7ca1561 > ql/src/test/results/clientpositive/llap/bucket5.q.out ef5067b6b7 > ql/src/test/results/clientpositive/llap/bucket_many.q.out 72b0ec4ed2 > ql/src/test/results/clientpositive/llap/bucketmapjoin1.q.out 6338f66c60 > ql/src/test/results/clientpositive/llap/bucketmapjoin2.q.out 7e3d6063b5 > ql/src/test/results/clientpositive/llap/bucketmapjoin3.q.out 00cf0f1dd1 > ql/src/test/results/clientpositive/llap/bucketmapjoin4.q.out 7b983f0d8e > > ql/src/test/results/clientpositive/llap/column_names_with_leading_and_trailing_spaces.q.out > bc9258f11f > ql/src/test/results/clientpositive/llap/disable_merge_for_bucketing.q.out > ca03652198 > ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out > 1d1f86bfaa > ql/src/test/results/clientpositive/llap/dynamic_semijoin_user_level.q.out > b910df4f34 > ql/src/test/results/clientpositive/llap/join32_lessSize.q.out 5c2e3d41a8 > ql/src/test/results/clientpositive/llap/metadataonly1.q.out 27218cf599 > ql/src/test/results/clientpositive/llap/orc_create.q.out 893ca41a8c > ql/src/test/results/clientpositive/llap/reduce_deduplicate.q.out 2cc6f5d317 > ql/src/test/results/clientpositive/llap/sample1.q.out 61a3a0f43f > ql/src/test/results/clientpositive/llap/stats11.q.out c71a71e09d > ql/src/test/results/clientpositive/parquet_array_null_element.q.out > 75d2d274dc > ql/src/test/results/clientpositive/parquet_create.q.out cc4b7357a0 > ql/src/test/results/clientpositive/parquet_int96_timestamp.q.out b9a3664458 > ql/src/test/results/clientpositive/part_inherit_tbl_props.q.out 077b1f11cf > ql/src/test/results/clientpositive/part_inherit_tbl_props_empty.q.out > 95c2d6ed6a > ql/src/test/results/clientpositive/part_inherit_tbl_props_with_star.q.out > 6036e5cda1 > ql/src/test/results/clientpositive/partial_column_stats.q.out f204a18144 > ql/src/test/results/clientpositive/partition_coltype_literals.q.out > 3affc947c6 > ql/src/test/results/clientpositive/pcr.q.out a1301fdf79 > ql/src/test/results/clientpositive/quotedid_stats.q.out a8cbb74691 > ql/src/test/results/clientpositive/rand_partitionpruner2.q.out fa4aae8d8d > ql/src/test/results/clientpositive/rcfile_default_format.q.out bb846c0fbc > ql/src/test/results/clientpositive/sample1.q.out 1947e92e4b > ql/src/test/results/clientpositive/sample2.q.out 9c5e238dec > ql/src/test/results/clientpositive/sample4.q.out 20bd86c1e3 > ql/src/test/results/clientpositive/sample5.q.out 0ed1fb22d1 > ql/src/test/results/clientpositive/sample6.q.out 1988a9067b > ql/src/test/results/clientpositive/sample7.q.out 7de68a8a8c > ql/src/test/results/clientpositive/show_tblproperties.q.out 005de89c63 > ql/src/test/results/clientpositive/spark/bucket2.q.out 540e6f8610 > ql/src/test/results/clientpositive/spark/bucket4.q.out d944a5ea41 > ql/src/test/results/clientpositive/spark/bucket5.q.out 1d0438cb7f > ql/src/test/results/clientpositive/spark/bucket_map_join_spark1.q.out > 0fcf844903 > ql/src/test/results/clientpositive/spark/bucket_map_join_spark2.q.out > 01f10038a1 > ql/src/test/results/clientpositive/spark/bucket_map_join_spark3.q.out > 244ac035dc > ql/src/test/results/clientpositive/spark/bucketmapjoin1.q.out 1b47864992 > ql/src/test/results/clientpositive/spark/bucketmapjoin2.q.out 58a2935d2d > ql/src/test/results/clientpositive/spark/bucketmapjoin3.q.out 6ac97a1f17 > ql/src/test/results/clientpositive/spark/bucketmapjoin4.q.out c1ea0ab9cc > ql/src/test/results/clientpositive/spark/bucketmapjoin5.q.out fc95d1361f > ql/src/test/results/clientpositive/spark/bucketmapjoin_negative.q.out > f4537ffc3f > ql/src/test/results/clientpositive/spark/bucketmapjoin_negative2.q.out > 50a726e502 > ql/src/test/results/clientpositive/spark/disable_merge_for_bucketing.q.out > 5dd79de590 > ql/src/test/results/clientpositive/spark/groupby_map_ppr.q.out 34a01e2541 > > ql/src/test/results/clientpositive/spark/groupby_map_ppr_multi_distinct.q.out > d4fd0bb168 > ql/src/test/results/clientpositive/spark/groupby_ppr.q.out 88fc15b733 > ql/src/test/results/clientpositive/spark/groupby_ppr_multi_distinct.q.out > 5851472990 > ql/src/test/results/clientpositive/spark/groupby_sort_1_23.q.out 418f3ec6ac > ql/src/test/results/clientpositive/spark/groupby_sort_skew_1_23.q.out > f7fca5dea5 > ql/src/test/results/clientpositive/spark/input_part2.q.out 6387ed18e4 > ql/src/test/results/clientpositive/spark/join17.q.out c718916103 > ql/src/test/results/clientpositive/spark/join26.q.out b1de987412 > ql/src/test/results/clientpositive/spark/join32.q.out c93411ee3c > ql/src/test/results/clientpositive/spark/join32_lessSize.q.out e658e1a4eb > ql/src/test/results/clientpositive/spark/join33.q.out c93411ee3c > ql/src/test/results/clientpositive/spark/join34.q.out 86ddd1d2be > ql/src/test/results/clientpositive/spark/join35.q.out 74b1ee4e7e > ql/src/test/results/clientpositive/spark/join9.q.out 9b5b243fb2 > ql/src/test/results/clientpositive/spark/join_map_ppr.q.out 67b2e941ce > ql/src/test/results/clientpositive/spark/pcr.q.out 77ac020d07 > ql/src/test/results/clientpositive/spark/reduce_deduplicate.q.out > 93b026f655 > ql/src/test/results/clientpositive/spark/sample1.q.out b44a0e8a79 > ql/src/test/results/clientpositive/spark/sample2.q.out c109918c07 > ql/src/test/results/clientpositive/spark/sample4.q.out 31b9aa890c > ql/src/test/results/clientpositive/spark/sample5.q.out 71e0f42299 > ql/src/test/results/clientpositive/spark/sample6.q.out 37545af54d > ql/src/test/results/clientpositive/spark/sample7.q.out 34c293ccc2 > ql/src/test/results/clientpositive/spark/stats0.q.out 6992ffabc6 > ql/src/test/results/clientpositive/spark/stats3.q.out 10fe00f5df > ql/src/test/results/clientpositive/stats0.q.out 01e00c8780 > ql/src/test/results/clientpositive/stats3.q.out 10fe00f5df > ql/src/test/results/clientpositive/unicode_notation.q.out 506fc7560a > ql/src/test/results/clientpositive/unset_table_view_property.q.out > d28d800e50 > > > Diff: https://reviews.apache.org/r/58935/diff/1/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
