----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59080/ -----------------------------------------------------------
(Updated May 10, 2017, 7:59 p.m.) Review request for hive and Jason Dere. Changes ------- Rewrote the hint parsing logic. Repository: hive-git Description ------- Semijoin Hint : Should able to handle more than 1 hint per alias. - If a user provides a hint, only that semijoin optimization is performed. - If there are more than 1 hints for an alias, it is upto user to make sure the (alias + colName) combo is unique. - Works with join aliases. - Refactored the logic to generate semijoin to keep the inner loops count down. Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 99c26ce80e ql/src/java/org/apache/hadoop/hive/ql/optimizer/DynamicPartitionPruningOptimization.java f56b9cbb18 ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 6de4bcd64a ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 5115fc8090 ql/src/java/org/apache/hadoop/hive/ql/parse/SemiJoinHint.java 1f24e23ff3 ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java 01fab9c5d6 ql/src/test/queries/clientpositive/semijoin_hint.q 5fbc273e7d ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out e3ffcfa857 ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_2.q.out 650dc9ffd7 ql/src/test/results/clientpositive/llap/dynamic_semijoin_user_level.q.out 0098b893f4 ql/src/test/results/clientpositive/llap/semijoin_hint.q.out 3ffc2352a4 Diff: https://reviews.apache.org/r/59080/diff/3/ Changes: https://reviews.apache.org/r/59080/diff/2-3/ Testing ------- Thanks, Deepak Jaiswal
