-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2922/
-----------------------------------------------------------

Review request for hive and John Sichi.


Summary
-------

Select * case provided group by validation like select columns list is subset 
or equal to the group by columns list. If it violates this validation will 
throw exception.


This addresses bug HIVE-2099.
    https://issues.apache.org/jira/browse/HIVE-2099


Diffs
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
1203044 
  trunk/ql/src/test/queries/clientnegative/groupby_select_all.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/groupby_select_all_alias.q 
PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/groupby_select_all_join.q 
PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/groupby_select_all_subquery.q 
PRE-CREATION 
  
trunk/ql/src/test/queries/clientnegative/groupby_select_all_subquery_unionall.q 
PRE-CREATION 
  trunk/ql/src/test/queries/clientpositive/groupby_select_all.q PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/groupby_select_all.q.out 
PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/groupby_select_all_alias.q.out 
PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/groupby_select_all_join.q.out 
PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/groupby_select_all_subquery.q.out 
PRE-CREATION 
  
trunk/ql/src/test/results/clientnegative/groupby_select_all_subquery_unionall.q.out
 PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/groupby_select_all.q.out 
PRE-CREATION 

Diff: https://reviews.apache.org/r/2922/diff


Testing
-------

All unit tests passed and added new testcases


Thanks,

chinna

Reply via email to