-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58086/
-----------------------------------------------------------
(Updated April 5, 2017, 5:21 p.m.)
Review request for hive, Aihua Xu, Chaoyu Tang, Marta Kuczora, Miklos Csanady,
and Barna Zsombor Klara.
Changes
-------
Changed default value from -1 to Integer.MAX_VALUE as suggested by Vihang.
Added extra test cases for edge cases
Bugs: HIVE-16334
https://issues.apache.org/jira/browse/HIVE-16334
Repository: hive-git
Description
-------
The patch contains the following changes:
- Added a new config variable which defines the maximum length of the query
string in the lock object
- When constructing the HiveLockObject gets the configuration as a new parameter
- When constructing the HiveLockObject truncates the length of the query string
if it is necessary
- Updates every occurance of the HiveLockObject creation
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6de6ed6
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java 53ee9c8
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java fff03df
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveTxnManagerImpl.java a371a5a
ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDummyTxnManager.java
de3b8ad
ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestEmbeddedLockManager.java
0afbc1c
ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestHiveLockObject.java 19cb129
ql/src/test/org/apache/hadoop/hive/ql/lockmgr/zookeeper/TestZookeeperLockManager.java
3f9926e
Diff: https://reviews.apache.org/r/58086/diff/2/
Changes: https://reviews.apache.org/r/58086/diff/1-2/
Testing
-------
Added new unit test to test the truncation
Updated the existing unit tests
Thanks,
Peter Vary
