-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56290/#review170427
-----------------------------------------------------------




accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloStorageHandler.java
Lines 250 (patched)
<https://reviews.apache.org/r/56290/#comment243255>

    I think you need to wrap this in a `if (null != indexTable)`. These 
properties are eventually serialized into the `Job`'s `Configuration`. (re: the 
JIRA comment I left)


- Josh Elser


On March 6, 2017, 4:24 p.m., Mike Fagan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56290/
> -----------------------------------------------------------
> 
> (Updated March 6, 2017, 4:24 p.m.)
> 
> 
> Review request for hive and Josh Elser.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-15795: Add Accumulo Index Table Support
> 
> 
> Diffs
> -----
> 
>   
> accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloDefaultIndexScanner.java
>  PRE-CREATION 
>   
> accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloIndexLexicoder.java
>  PRE-CREATION 
>   
> accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloIndexScanner.java
>  PRE-CREATION 
>   
> accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloIndexScannerException.java
>  PRE-CREATION 
>   
> accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloStorageHandler.java
>  cdbc7f2 
>   
> accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/mr/AccumuloIndexDefinition.java
>  PRE-CREATION 
>   
> accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/mr/AccumuloIndexedOutputFormat.java
>  PRE-CREATION 
>   
> accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/mr/HiveAccumuloTableOutputFormat.java
>  3ae5431 
>   
> accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/mr/IndexOutputConfigurator.java
>  PRE-CREATION 
>   
> accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/mr/package-info.java
>  PRE-CREATION 
>   
> accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/predicate/AccumuloPredicateHandler.java
>  a7ec7c5 
>   
> accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/predicate/AccumuloRangeGenerator.java
>  21392d1 
>   
> accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/predicate/PrimitiveComparisonFilter.java
>  17d5529 
>   
> accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/serde/AccumuloIndexParameters.java
>  PRE-CREATION 
>   
> accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/serde/AccumuloSerDeParameters.java
>  09c5f24 
>   
> accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/serde/package-info.java
>  PRE-CREATION 
>   
> accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/TestAccumuloDefaultIndexScanner.java
>  PRE-CREATION 
>   
> accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/TestAccumuloIndexLexicoder.java
>  PRE-CREATION 
>   
> accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/TestAccumuloIndexParameters.java
>  PRE-CREATION 
>   
> accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/TestAccumuloStorageHandler.java
>  0aaa782 
>   
> accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/predicate/TestAccumuloPredicateHandler.java
>  88e4530 
>   
> accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/predicate/TestAccumuloRangeGenerator.java
>  339da07 
>   accumulo-handler/src/test/queries/positive/accumulo_queries.q 279b661 
> 
> 
> Diff: https://reviews.apache.org/r/56290/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mike Fagan
> 
>

Reply via email to