----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57805/#review170201 -----------------------------------------------------------
common/src/java/org/apache/hive/http/HttpServer.java Lines 101-108 (patched) <https://reviews.apache.org/r/57805/#comment242983> Wouldn't be good to wrap this code into a private method that creates the server? It will make the constructor cleaner if we see this: webServer = createServer(b); appDir = getWebAppsPath(b.name); webAppContext = createWebAppContext(b); common/src/java/org/apache/hive/http/HttpServer.java Line 393 (original), 402 (patched) <https://reviews.apache.org/r/57805/#comment242986> Should we declare a final static variable for the 200 number? probably add a comment why 200 is a good value? was it unlimited before? - Sergio Pena On March 27, 2017, 4:31 p.m., Aihua Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57805/ > ----------------------------------------------------------- > > (Updated March 27, 2017, 4:31 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-16049: upgrade to jetty 9 > > > Diffs > ----- > > common/pom.xml 8474a87 > common/src/java/org/apache/hive/http/HttpServer.java db5650d > hcatalog/pom.xml 34de177 > hcatalog/webhcat/svr/pom.xml c5ad387 > > hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/Main.java > 5208bf4 > llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java > 22e5ee8 > pom.xml 4c73e27 > service/pom.xml 9306739 > > service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java > ebec165 > service/src/test/org/apache/hive/service/server/TestHS2HttpServer.java > 4d50dd9 > > > Diff: https://reviews.apache.org/r/57805/diff/2/ > > > Testing > ------- > > > Thanks, > > Aihua Xu > >
