[ 
https://issues.apache.org/jira/browse/HIVE-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154702#comment-13154702
 ] 

Phabricator commented on HIVE-2561:
-----------------------------------

jsichi has commented on the revision "HIVE-2561 [jira] Add an annotation to 
UDFs to allow them to specify additional FILE/JAR resources necessary for 
execution".

INLINE COMMENTS
  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:1091 The 
stateful annotation is intended for stuff like running sum, where the state 
seen so far affects the results of future evaluations.

  The presence of internal state (e.g. file handle) is unrelated to stateful 
behavior.

  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInFile.java:41 
Unit tests run in something like local mode, so for stuff like this, it's 
usually a good idea to test on a real cluster too.  It's fine to either test 
now, or wait until after it gets committed and then test later and open up a 
new JIRA issue if there's a problem.

REVISION DETAIL
  https://reviews.facebook.net/D507

                
> Allow UDFs to specify additional FILE/JAR resources necessary for execution
> ---------------------------------------------------------------------------
>
>                 Key: HIVE-2561
>                 URL: https://issues.apache.org/jira/browse/HIVE-2561
>             Project: Hive
>          Issue Type: New Feature
>            Reporter: Jonathan Chang
>            Assignee: Jonathan Chang
>         Attachments: HIVE-2561.D507.1.patch
>
>
> Often times UDFs will have dependencies to external JARs/FILEs.  It makes 
> sense for these to be encoded by the UDF (rather than having the caller 
> remember the set of files that need to be ADDed).  Let's add an annotation to 
> UDFs which will cause these resources to be auto-added.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to