----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57503/#review168969 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/common/FixedSizeCollection.java Lines 32 (patched) <https://reviews.apache.org/r/57503/#comment241309> Since we already use common-collections library in hive, would using something like FixedSizeList or something else address the same purpose instead of having to add a new class? common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Line 781 (original), 781 (patched) <https://reviews.apache.org/r/57503/#comment241308> We already a few config properties around the max batch sizes for tables/partitions. Would it make sense to re-use one of them? They are for the same purpose, whether it be for read or write. METASTORE_BATCH_RETRIEVE_TABLE_PARTITION_MAX METASTORE_DIRECT_SQL_PARTITION_BATCH_SIZE HIVE_MSCK_REPAIR_BATCH_SIZE METASTORE_BATCH_RETRIEVE_MAX - Naveen Gangam On March 10, 2017, 10:36 a.m., Barna Zsombor Klara wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57503/ > ----------------------------------------------------------- > > (Updated March 10, 2017, 10:36 a.m.) > > > Review request for hive, Peter Vary, Sergio Pena, Sahil Takiar, and Vihang > Karajgaonkar. > > > Repository: hive-git > > > Description > ------- > > HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/FixedSizeCollection.java > PRE-CREATION > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > a479deb7c0c6b779277f1029009b7dfab6dcb9e3 > common/src/test/org/apache/hadoop/hive/common/TestFixedSizeCollection.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java > 6805c17a116f5ef0febd36c59d454fa631ae0024 > ql/src/test/queries/clientnegative/msck_repair_4.q PRE-CREATION > ql/src/test/queries/clientpositive/msck_repair_0.q > ce8ef426a2a58845afc8333259d66725db416584 > ql/src/test/results/clientnegative/msck_repair_4.q.out PRE-CREATION > ql/src/test/results/clientpositive/msck_repair_0.q.out > 3f2fe75b194f1248bd5c073dd7db6b71b2ffc2ba > > > Diff: https://reviews.apache.org/r/57503/diff/1/ > > > Testing > ------- > > Tested locally and added qtests/unit tests. > > > Thanks, > > Barna Zsombor Klara > >
