-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57343/
-----------------------------------------------------------
(Updated March 8, 2017, 3:03 p.m.)
Review request for hive, Zoltan Haindrich, Naveen Gangam, Sergio Pena, Vihang
Karajgaonkar, and Barna Zsombor Klara.
Changes
-------
Addressed review comments. Thanks for all of you who reviewed!
Removed resetting the hooks, since the client session is closed anyway
Changed the formatting of the String[] initialization to be more readable
Bugs: HIVE-16127
https://issues.apache.org/jira/browse/HIVE-16127
Repository: hive-git
Description
-------
Refactored the QFileClient:
- Moved to itest/util
- Separated QFile specific code parts (file path, and filtering)
- Separated BeeLineClient specific code (execution of the queries, commands)
- Created factories for QFile, and Client, so after initialization they can be
reused during multiple tests
- Separated init script run from actual test run, so multiple tests could be
run against a single MiniHS2 instance
- Removed unused property
Diffs (updated)
-----
beeline/src/java/org/apache/hive/beeline/util/QFileClient.java d306b7f
itests/src/test/resources/testconfiguration.properties b01ebd8
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java
aba1fde
itests/util/src/main/java/org/apache/hive/beeline/qfile/QFile.java
PRE-CREATION
itests/util/src/main/java/org/apache/hive/beeline/qfile/QFileBeeLineClient.java
PRE-CREATION
itests/util/src/main/java/org/apache/hive/beeline/qfile/package-info.java
PRE-CREATION
ql/src/test/results/clientpositive/beeline/drop_with_concurrency.q.out
PRE-CREATION
Diff: https://reviews.apache.org/r/57343/diff/2/
Changes: https://reviews.apache.org/r/57343/diff/1-2/
Testing
-------
Used the previosly generated test to validate that the result is not changed.
Added one more test to check the separation is done correctly.
Thanks,
Peter Vary
