> On Jan. 27, 2017, 4:18 p.m., Sergio Pena wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java > > Lines 968 (patched) > > <https://reviews.apache.org/r/54065/diff/1/?file=1570137#file1570137line968> > > > > shouldn't be easier if we set the dataLocation modification time first > > to lastModificationTime, and then compare this value with the rest of the > > partitions found? This way we could avoid the null value and the Long > > object, and use long instead.
Thanks a lot for the review! Yeah, you are right, I fixed it. - Marta ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54065/#review163281 ----------------------------------------------------------- On Dec. 12, 2016, 1:04 p.m., Marta Kuczora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54065/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2016, 1:04 p.m.) > > > Review request for hive, Aihua Xu, Chaoyu Tang, Peter Vary, and Sergio Pena. > > > Bugs: HIVE-15282 > https://issues.apache.org/jira/browse/HIVE-15282 > > > Repository: hive-git > > > Description > ------- > > Changed the way how the modification time is determined for partitions in the > DDLTask.alterIndex method to be the same as when the index staleness is > checked. Instead of using the modification date of the partition folder, go > through the files in the folder and use the highest modification time and > save it as index property. With this we can avoid the issue when the folder > and the file is created when the second turns. So the modification time of > the folder is in the previous second compared to the modification time of the > file. > If the partition folder doesn't contain any files, then use the folder's > modification time, just as before. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java cfece77 > > > Diff: https://reviews.apache.org/r/54065/diff/1/ > > > Testing > ------- > > Ran the index_auto_mult_tables_compact and index_auto_mult_tables q tests > multiple times, with hard-coded delay with which the test failure described > in HIVE-15282 could be reproduced. With the patch, the tests were always > successful. > Also ran all index related q tests. > > > Thanks, > > Marta Kuczora > >
