> On Feb. 22, 2017, 6:04 p.m., Illya Yalovyy wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java, line 2081 > > <https://reviews.apache.org/r/56688/diff/3/?file=1642558#file1642558line2081> > > > > I feel like we need a unit test for this method.
Agree. It is a private method, but I made it visible for testing now. - Sergio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56688/#review166384 ----------------------------------------------------------- On Feb. 22, 2017, 4:28 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56688/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2017, 4:28 p.m.) > > > Review request for hive. > > > Bugs: HIVE-15881 > https://issues.apache.org/jira/browse/HIVE-15881 > > > Repository: hive-git > > > Description > ------- > > Deprecates the use of mapred.dfsclient.parallelism.max, and instead use > hive.exec.input.listing.max.threads > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > 1af59ba5879d3ad24148fa86f8ce725acef2bb63 > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java > e81cbce3e333d44a4088c10491f399e92a505293 > ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java > 5a9d83ca4890a68a63f8f6c145d30906a58c7e73 > > Diff: https://reviews.apache.org/r/56688/diff/ > > > Testing > ------- > > Added tests to TestUtilities. > Waiting for HiveQA > > > Thanks, > > Sergio Pena > >
