----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56902/#review166276 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java (line 799) <https://reviews.apache.org/r/56902/#comment238190> Declare string constants as class variable. ql/src/java/org/apache/hadoop/hive/ql/optimizer/AnnotateReduceSinkOutputOperator.java (lines 44 - 48) <https://reviews.apache.org/r/56902/#comment238192> Copy-paste? ql/src/test/queries/clientpositive/explain_formatted_oid.q (line 1) <https://reviews.apache.org/r/56902/#comment238196> This should not be necessary. May as well. - Ashutosh Chauhan On Feb. 21, 2017, 11:13 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56902/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2017, 11:13 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > HIVE-15955 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 74cec3e > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/AnnotateReduceSinkOutputOperator.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java c6287e4 > ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceSinkDesc.java b8c2d42 > ql/src/test/queries/clientpositive/explain_formatted_oid.q PRE-CREATION > ql/src/test/results/clientpositive/explain_formatted_oid.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/56902/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
