----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56775/#review165988 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java (line 347) <https://reviews.apache.org/r/56775/#comment237857> remove ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java (line 351) <https://reviews.apache.org/r/56775/#comment237874> This may traverse full tree if SETCOLREF is not present in AST, which will be a common case. That could be expensive. ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java (line 355) <https://reviews.apache.org/r/56775/#comment237859> remove ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java (line 375) <https://reviews.apache.org/r/56775/#comment237856> LOG.debug? ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java (line 389) <https://reviews.apache.org/r/56775/#comment237862> log.debug ? ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java (line 408) <https://reviews.apache.org/r/56775/#comment237872> In case of malformed query with unbalanced number of columns in diff branches of union we will pick first one? One malformed AST will translate into another. I think that will fail later, but might be good idea to add comment here that check is not done here. ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java (line 414) <https://reviews.apache.org/r/56775/#comment237871> debug ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java (line 466) <https://reviews.apache.org/r/56775/#comment237873> debug? ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java (line 489) <https://reviews.apache.org/r/56775/#comment237875> debug? - Ashutosh Chauhan On Feb. 17, 2017, 8:39 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56775/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2017, 8:39 p.m.) > > > Review request for hive, Ashutosh Chauhan and Jesús Camacho Rodríguez. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java 2423471 > > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java > 89c87cd > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java > e36e1bd > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteParseContextGenerator.java > 340d29a > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java e7687be > > ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsAutoGatherContext.java > 80e62c1 > > ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java > ff07b42 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g eb81393 > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java 943e6af > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java f053093 > > ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java > 12a43a2 > ql/src/java/org/apache/hadoop/hive/ql/tools/LineageInfo.java 12154c9 > ql/src/test/org/apache/hadoop/hive/ql/parse/TestMacroSemanticAnalyzer.java > c659806 > > ql/src/test/org/apache/hadoop/hive/ql/parse/TestUpdateDeleteSemanticAnalyzer.java > d6fe540 > > ql/src/test/org/apache/hadoop/hive/ql/parse/authorization/AuthorizationTestUtil.java > e8e29ee > ql/src/test/queries/clientpositive/union_pos_alias.q PRE-CREATION > ql/src/test/results/clientpositive/union10.q.out 85eabf5 > ql/src/test/results/clientpositive/union_pos_alias.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/56775/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
