----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56110/#review163636 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java (line 663) <https://reviews.apache.org/r/56110/#comment235113> Another option here might have been to put more of the checking into the NodeProcessor implementation, and return just the items that need to be removed. - Jason Dere On Jan. 31, 2017, 3:01 a.m., Deepak Jaiswal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56110/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2017, 3:01 a.m.) > > > Review request for hive and Jason Dere. > > > Bugs: HIVE-15760 > https://issues.apache.org/jira/browse/HIVE-15760 > > > Repository: hive-git > > > Description > ------- > > Fix ConcurrentModification Excpetion when removing semijoin operator due to a > cycle created by Mapjoin-Mapjoin-semijoin. > > It now traverses the graph and prepares a list of potential candidates and > then processes them in 2nd pass. > Did the similar changes for SMBJoin related semijoin removal logic. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java cf8e843 > > Diff: https://reviews.apache.org/r/56110/diff/ > > > Testing > ------- > > > Thanks, > > Deepak Jaiswal > >
