-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56025/#review163534
-----------------------------------------------------------
Hi Remus,
I am not too familiar how the colstats are propagated, but currently wokring on
enabling yetus on Hive.
Yetus runs several checks which might help the work of the reviewers. Here is
what Yetus found with the checkstyle plugin:
./ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java:47:import
org.apache.hadoop.hive.ql.Context;:8: warning: Unused import -
org.apache.hadoop.hive.ql.Context.
./ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java:399:
LogHelper console = SessionState.getConsole();: warning: if child
at indentation level 12 not at correct indentation, 10
./ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java:400:
console.printInfoNoLog(logMsg);: warning: if child at indentation
level 12 not at correct indentation, 10
./ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java:1103:
if (!getIsSilent()) {: warning: if at indentation level 8 not at correct
indentation, 6
./ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java:1104:
getInfoStream().println(info);: warning: if child at indentation level 10 not
at correct indentation, 8
./ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java:1105:
}: warning: if rcurly at indentation level 8 not at correct indentation, 6
./ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java:1106: }:
warning: method def rcurly at indentation level 6 not at correct indentation, 4
Running Findbugs, ASF header check, etc did not found any new problems.
Thanks for the patch!
Peter
- Peter Vary
On Jan. 30, 2017, 10:30 a.m., Remus Rusanu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56025/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2017, 10:30 a.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Propagate the message logged in RelOpHiveTable.updateColStats to the session.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 4e83867
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java
> 009d9e5
> ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 453e0a5
> ql/src/test/queries/clientpositive/stats_missing_warning.q PRE-CREATION
> ql/src/test/results/clientpositive/stats_missing_warning.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/56025/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Remus Rusanu
>
>
