-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55816/#review163528
-----------------------------------------------------------
Hi Anthony,
I am not too familiar with the ORC tables, but currently wokring on enabling
yetus on Hive.
Yetus runs several checks which might help the work of the reviewers. Here is
what Yetus found with the checkstyle plugin:
./ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java:3679:
addTableSchemaToConf(conf, tableScanOp.getSchemaEvolutionColumns(),
tableScanOp.getSchemaEvolutionColumnsTypes());: warning: Line is longer than
100 characters (found 118).
./ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java:3688:
LOG.info(IOConstants.SCHEMA_EVOLUTION_COLUMNS + " and " +
IOConstants.SCHEMA_EVOLUTION_COLUMNS_TYPES +: warning: Line is longer than 100
characters (found 108).
./ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java:610:
pushFilters(jobConf, filterExpr, filterObj, serializedFilterObj,
serializedFilterExpr, tableScan.getSchema(),: warning: Line is longer than 100
characters (found 113).
./ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java:614: public
static void pushFilters(JobConf jobConf, ExprNodeGenericFuncDesc filterExpr,
Serializable filterObject,: warning: Line is longer than 100 characters (found
112).
./ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java:614: public
static void pushFilters(JobConf jobConf, ExprNodeGenericFuncDesc filterExpr,
Serializable filterObject,:22: warning: More than 7 parameters (found 8).
./ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java:615:
String serializedFilterObj, String serializedFilterExpr, RowSchema rowSchema,
String schemaEvolutionColumns,: warning: Line is longer than 100 characters
(found 114).
./ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java:743:
pushFilters(jobConf, tableFilterExpr, filterObject, serializedFilterObj,
serializedFilterExpr, rowSchema,: warning: Line is longer than 100 characters
(found 109).
./ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java:747: private
Set<String> getAliasesForPath(Path splitPath, boolean nonNative, Path
splitPathWithNoSchema) {: warning: Line is longer than 100 characters (found
104).
./ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java:791: private
ExprNodeGenericFuncDesc buildTableFilterExpr(boolean noFilters,
List<ExprNodeGenericFuncDesc> filterExprs) {: warning: Line is longer than 100
characters (found 118).
./ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java:796:
if (tableFilterExpr == null ) {:38: warning: ')' is preceded with whitespace.
Running Findbugs, ASF header check, etc did not found any new problems.
Thanks for the patch!
Peter
- Peter Vary
On Jan. 28, 2017, 9:41 p.m., Anthony Hsu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55816/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2017, 9:41 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-15680
> https://issues.apache.org/jira/browse/HIVE-15680
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-15680: Incorrect results when hive.optimize.index.filter=true and same
> ORC table is referenced twice in query
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
> 1cf24b41c047b9bc43e42a2940ff54a3e331190c
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java
> 3ee8fdc24aa115710d2c42f5c44c7f28e0544589
> ql/src/test/queries/clientpositive/orc_ppd_same_table_multiple_aliases.q
> PRE-CREATION
>
> ql/src/test/results/clientpositive/orc_ppd_same_table_multiple_aliases.q.out
> PRE-CREATION
> serde/src/java/org/apache/hadoop/hive/serde2/ColumnProjectionUtils.java
> 1354680584305bc7ea928526160f08fc9cbfd73e
>
> Diff: https://reviews.apache.org/r/55816/diff/
>
>
> Testing
> -------
>
> Added qtest.
>
>
> Thanks,
>
> Anthony Hsu
>
>
