-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55553/
-----------------------------------------------------------
Review request for hive and Ashutosh Chauhan.
Bugs: HIVE-15544
https://issues.apache.org/jira/browse/HIVE-15544
Repository: hive-git
Description
-------
This patch provides support for scalar subqueries in filter clause. This patch
has following outstanding issues:
* Various restriction checks. This patch disables current subquery restriction
check since these checks don't expect scalar subqueries and throw exception.
* This patch produces wrong result for correlated scalar subqueries if there is
a non-equi predicate on correlated vars.
Diffs
-----
itests/src/test/resources/testconfiguration.properties be5a747
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 6f01da0
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelDecorrelator.java
a373cdd
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSubQueryRemoveRule.java
f1e8ebd
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java
8d2e535
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 9f1b9d5
ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g cd9adfc
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java f275f6a
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 6c30efd
ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeSubQueryDesc.java aec331b
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSQCountCheck.java
PRE-CREATION
ql/src/test/queries/clientnegative/subquery_scalar_multi_columns.q
PRE-CREATION
ql/src/test/queries/clientnegative/subquery_scalar_multi_rows.q PRE-CREATION
ql/src/test/queries/clientpositive/perf/query1.q PRE-CREATION
ql/src/test/queries/clientpositive/perf/query23.q e8ebd86
ql/src/test/queries/clientpositive/perf/query30.q PRE-CREATION
ql/src/test/queries/clientpositive/perf/query41.q PRE-CREATION
ql/src/test/queries/clientpositive/perf/query6.q PRE-CREATION
ql/src/test/queries/clientpositive/perf/query81.q PRE-CREATION
ql/src/test/queries/clientpositive/subquery_scalar.q PRE-CREATION
ql/src/test/results/clientnegative/subquery_scalar_multi_rows.q.out
PRE-CREATION
ql/src/test/results/clientpositive/llap/subquery_multi.q.out 7765221
ql/src/test/results/clientpositive/llap/subquery_notin.q.out eb99650
ql/src/test/results/clientpositive/llap/subquery_scalar.q.out PRE-CREATION
ql/src/test/results/clientpositive/perf/query1.q.out PRE-CREATION
ql/src/test/results/clientpositive/perf/query23.q.out 6d4cfca
ql/src/test/results/clientpositive/perf/query30.q.out PRE-CREATION
ql/src/test/results/clientpositive/perf/query41.q.out PRE-CREATION
ql/src/test/results/clientpositive/perf/query6.q.out PRE-CREATION
ql/src/test/results/clientpositive/perf/query81.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/55553/diff/
Testing
-------
Added q tests
Thanks,
Vineet Garg
