-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55498/
-----------------------------------------------------------
(Updated Jan. 13, 2017, 3:26 p.m.)
Review request for hive and Chaoyu Tang.
Changes
-------
Improved the test according to the review:
- verify the returned values instead of just checking the number of returned
records
- extract the exception message in HiveMetaStore to a public constant and use
it in the test
Bugs: HIVE-15538
https://issues.apache.org/jira/browse/HIVE-15538
Repository: hive-git
Description
-------
Added unit test for testing HIVE-13884 with more complex queries and
hive.metastore.limit.partition.request enabled.
It covers cases when the query predicates can be pushed down and the number of
partitions can be retrieved via directSQL.
It also covers cases when the number of partitions cannot be retrieved via
directSQL, so it falls back to ORM.
Diffs (updated)
-----
data/files/max_partition_test_input.txt PRE-CREATION
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestMetaStoreLimitPartitionRequest.java
PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
121b825
Diff: https://reviews.apache.org/r/55498/diff/
Testing
-------
The patch contains only a new unit test. Ran the test multiple times
successfully.
Thanks,
Marta Kuczora
