> On Jan. 6, 2017, 3:25 a.m., Jason Dere wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 2840 > > <https://reviews.apache.org/r/55156/diff/2/?file=1596502#file1596502line2840> > > > > This setting should probably default to false for the time being
Will do it at the very end to ensure test coverage. > On Jan. 6, 2017, 3:25 a.m., Jason Dere wrote: > > orc/src/java/org/apache/orc/impl/RecordReaderImpl.java, line 30 > > <https://reviews.apache.org/r/55156/diff/2/?file=1596503#file1596503line30> > > > > Looks like this is an unnecessary change - remove this. Thanks. Coming in v7. > On Jan. 6, 2017, 3:25 a.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeDynamicValueEvaluator.java, > > line 30 > > <https://reviews.apache.org/r/55156/diff/2/?file=1596511#file1596511line30> > > > > Looks left over from cut and paste - can you change to > > "ExprNodeDynamicValueEvaluator" Coming in v7. > On Jan. 6, 2017, 3:25 a.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeDynamicValueEvaluator.java, > > line 50 > > <https://reviews.apache.org/r/55156/diff/2/?file=1596511#file1596511line50> > > > > Can you move the call to setConf() up to the constructor so it is just > > done once? This requires DynamicValue which is not available in constructor. > On Jan. 6, 2017, 3:25 a.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/JoinUtil.java, line 143 > > <https://reviews.apache.org/r/55156/diff/2/?file=1596521#file1596521line143> > > > > This method takes in the extra conf parameter, but then doesn't do > > anything with it, it should be used by ExprNodeEvaluatorFactory.get() Coming in v7. > On Jan. 6, 2017, 3:25 a.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/ObjectCacheWrapper.java, line 38 > > <https://reviews.apache.org/r/55156/diff/2/?file=1596523#file1596523line38> > > > > leave this comment out :) Coming in v7. > On Jan. 6, 2017, 3:25 a.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ObjectCache.java, line 49 > > <https://reviews.apache.org/r/55156/diff/2/?file=1596525#file1596525line49> > > > > leave this comment out ditto. > On Jan. 6, 2017, 3:25 a.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DynamicValueRegistryTez.java, > > line 73 > > <https://reviews.apache.org/r/55156/diff/2/?file=1596526#file1596526line73> > > > > Nit: add @Override Coming in v7. > On Jan. 6, 2017, 3:25 a.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordProcessor.java, > > line 186 > > <https://reviews.apache.org/r/55156/diff/2/?file=1596530#file1596530line186> > > > > ReduceRecordProcessor is missing dynamicValueCache.release(), like > > MapRecordProcessor Coming in v7. > On Jan. 6, 2017, 3:25 a.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java, > > line 1200 > > <https://reviews.apache.org/r/55156/diff/2/?file=1596539#file1596539line1200> > > > > I think this change can be removed if we use the appropriate call to > > OperatorFactory.getAndMakeChild() during > > DynamicPartitionPruningOptimization. I'll try to play with this. Can you please elaborate and let me know your findings? - Deepak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55156/#review160516 ----------------------------------------------------------- On Jan. 7, 2017, 1:34 a.m., Deepak Jaiswal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55156/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2017, 1:34 a.m.) > > > Review request for hive, Gopal V, Gunther Hagleitner, Jason Dere, Prasanth_J, > and Rajesh Balamohan. > > > Bugs: HIVE-15269 > https://issues.apache.org/jira/browse/HIVE-15269 > > > Repository: hive-git > > > Description > ------- > > HIVE-15269 min-max runtime filtering. > The patch also contains the patch for HIVE-15270. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 47db0c0 > itests/src/test/resources/testconfiguration.properties 1cebc70 > orc/src/java/org/apache/orc/impl/RecordReaderImpl.java 975804b > orc/src/test/org/apache/orc/impl/TestRecordReaderImpl.java cdd62ac > pom.xml 376197e > ql/src/java/org/apache/hadoop/hive/ql/exec/AbstractMapJoinOperator.java > 69ba4a2 > ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java 940f2dd > ql/src/java/org/apache/hadoop/hive/ql/exec/DynamicValueRegistry.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeColumnEvaluator.java > 24c8281 > > ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeConstantDefaultEvaluator.java > 89a75eb > ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeConstantEvaluator.java > 4fe72a0 > > ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeDynamicValueEvaluator.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluator.java b8d6ab7 > ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluatorFactory.java > 0d03d8f > ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluatorHead.java > 42685fb > ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluatorRef.java > 0a6b66a > ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeFieldEvaluator.java > ff32626 > > ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeGenericFuncEvaluator.java > 221abd9 > ql/src/java/org/apache/hadoop/hive/ql/exec/FilterOperator.java bd0d28c > ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java 46f0ecd > ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java > ac5331e > ql/src/java/org/apache/hadoop/hive/ql/exec/JoinUtil.java 9718c48 > ql/src/java/org/apache/hadoop/hive/ql/exec/ObjectCache.java 440e0a1 > ql/src/java/org/apache/hadoop/hive/ql/exec/ObjectCacheWrapper.java 9768efa > ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java 9049ddd > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ObjectCache.java 008f8a4 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DynamicValueRegistryTez.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapObjectCache.java 0141230 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/MapRecordProcessor.java > 955fa80 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ObjectCache.java 06dca00 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordProcessor.java > d80f201 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorMapJoinOperator.java > 0cb6c8a > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorSMBMapJoinOperator.java > 80b0a14 > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java > f6b6447 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/DynamicValueVectorExpression.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/io/sarg/ConvertAstToSearchArg.java > 9d900e4 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java > beed6b8 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/DynamicPartitionPruningOptimization.java > 26fcc45 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/FixedBucketPruningOptimizer.java > 9e9beb0 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/RedundantDynamicPruningConditionsRemoval.java > d9ce017 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java > aa1e509 > ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java e2363eb > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 35f34da > ql/src/java/org/apache/hadoop/hive/ql/parse/RuntimeValuesInfo.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java e8b003e > ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java cdb9e1b > ql/src/java/org/apache/hadoop/hive/ql/plan/BaseWork.java 13a0811 > ql/src/java/org/apache/hadoop/hive/ql/plan/DynamicValue.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDynamicValueDesc.java > PRE-CREATION > > ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestConvertAstToSearchArg.java > 93b50a6 > ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java > 8cbc26d > > ql/src/test/org/apache/hadoop/hive/ql/optimizer/physical/TestVectorizer.java > 3295372 > ql/src/test/queries/clientpositive/dynamic_semijoin_reduction.q > PRE-CREATION > ql/src/test/results/clientpositive/llap/dynamic_partition_pruning_2.q.out > 21d82d2 > ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out > PRE-CREATION > storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/LiteralDelegate.java > PRE-CREATION > > storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentFactory.java > 8fda95c > > storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java > 10d8c51 > > Diff: https://reviews.apache.org/r/55156/diff/ > > > Testing > ------- > > > Thanks, > > Deepak Jaiswal > >
