----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53619/#review160534 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java (line 190) <https://reviews.apache.org/r/53619/#comment231684> what is the difference between NON_DEFAULT and the following NON_EMPTY? common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java (line 205) <https://reviews.apache.org/r/53619/#comment231679> We still need to have a try catch block for "// For backward compatibility, if previous value can not be parsed to a json object, it will come here." Because we do not have a json object format in very old versions, this will throw exception but we would like to return false. common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java (line 213) <https://reviews.apache.org/r/53619/#comment231680> The same for the backward compatibility issue. common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java (line 287) <https://reviews.apache.org/r/53619/#comment231692> startsWith sounds not as good as previous "try catch block" common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java (line 296) <https://reviews.apache.org/r/53619/#comment231693> use TRUE please. common/src/test/org/apache/hadoop/hive/common/TestStatsSetupConst.java (line 90) <https://reviews.apache.org/r/53619/#comment231694> This makes me worry about the difference between golden files for tests when we try to release a product... Do you mean that order is not preserved when we print them out? Could u add more test cases for "described extended [tableName]"? Thanks. - pengcheng xiong On Dec. 9, 2016, 1:14 p.m., Zoltan Haindrich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53619/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2016, 1:14 p.m.) > > > Review request for hive. > > > Bugs: HIVE-15161 > https://issues.apache.org/jira/browse/HIVE-15161 > > > Repository: hive-git > > > Description > ------- > > * json.org has license issues > * jackson can provide a fully compatible alternative to it > * there are a few flakiness issues caused by the order of the map entries of > the columns...this can be addressed, org.json api was unfriendly in this > manner ;) > * fully backward compatible change > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java > 25c7508f51662773e913a176bee7c8bd223202d4 > common/src/test/org/apache/hadoop/hive/common/TestStatsSetupConst.java > 7a7ad424a8e53ed89c79592ced86c7c38eaf4e04 > > Diff: https://reviews.apache.org/r/53619/diff/ > > > Testing > ------- > > added unit test > > > Thanks, > > Zoltan Haindrich > >
