----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54771/#review159386 -----------------------------------------------------------
metastore/if/hive_metastore.thrift (line 815) <https://reviews.apache.org/r/54771/#comment230369> how about sending byte[] instead of converting to string here. byte[] is what we get straight from serializing the checksum metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONMessageFactory.java (line 274) <https://reviews.apache.org/r/54771/#comment230418> anything specific about ordering here ? List is implicitly ordered. Should the more generic List be used instead of ArrayList ? Also, this and getAsOrderedMap are used only in test. Should it be part of a test util method instead of JSONMessageFactory ? metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONMessageFactory.java (line 283) <https://reviews.apache.org/r/54771/#comment230417> what is "ordered" map ? should it be just getAsMap() ? ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 2281) <https://reviews.apache.org/r/54771/#comment230375> should we add empty checksum instead of skipping the addition of checksum ? That seems cleaner. In theory, you could have some files belonging to a file system that does support cksum and others that don't. If we skip, then the size will be non zero and there will be a mismatch. - Thejas Nair On Dec. 15, 2016, 9:55 a.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54771/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2016, 9:55 a.m.) > > > Review request for hive, Sushanth Sowmyan and Thejas Nair. > > > Bugs: HIVE-15294 > https://issues.apache.org/jira/browse/HIVE-15294 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-15294 > > > Diffs > ----- > > > hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java > 119801f > > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java > 690616d > metastore/if/hive_metastore.thrift baab31b > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > f7b2ed7 > metastore/src/java/org/apache/hadoop/hive/metastore/events/InsertEvent.java > 102754e > > metastore/src/java/org/apache/hadoop/hive/metastore/messaging/MessageFactory.java > adf2fd8 > > metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONInsertMessage.java > ef89b17 > > metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONMessageFactory.java > 0407210 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 750fdef > > Diff: https://reviews.apache.org/r/54771/diff/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >
