----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54139/#review157269 -----------------------------------------------------------
Thanks for the patch Pengcheng Xiong. Looks good to me, I just have one very minor nitpick. Do we need to add qtest for a public static untility method? This can be fairly easily covered by normal junit tests which would run significantly faster and be more resiliant to failures. - Barna Zsombor Klara On Nov. 28, 2016, 9:48 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54139/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2016, 9:48 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > HIVE-15297 > > > Diffs > ----- > > cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 5364ca6 > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 5bf23e7 > ql/src/test/queries/clientpositive/specialChar.q PRE-CREATION > ql/src/test/results/clientpositive/specialChar.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/54139/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
