[
https://issues.apache.org/jira/browse/HIVE-2489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150627#comment-13150627
]
jirapos...@reviews.apache.org commented on HIVE-2489:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2833/
-----------------------------------------------------------
(Updated 2011-11-15 17:44:57.275327)
Review request for hive and Carl Steinbach.
Changes
-------
fix typo.
(thanks, Ashutosh Chauhan)
Summary
-------
There're 3 ways to set port now - using default port, from cli(-p or old
style), HIVE_PORT/METASTORE_PORT system env.
And after this issue is fixed, there'll be another way to configure port.
So, it's necessary cleaning up these.
Previous setting port precedence looks like this "default port < system env <
CLI option"
(if higher one is set, then use it)
and, now it'll be "default port < system env < HiveConf < CLI option"
IMO, all other settings should be finally collected into a HiveConf object. So
I implemented this way for HiveMetaStore.
But in HiveServer, some configurations are only available through CLI options,
so I chose applying port number from HiveConf to previous CLI object.(which is
required minimum code change, and I thought moving other settings to HiveConf
is out of scope of this issue)
This addresses bug HIVE-2489.
https://issues.apache.org/jira/browse/HIVE-2489
Diffs (updated)
-----
shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java
aadb34d
metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java
a089269
service/src/java/org/apache/hadoop/hive/service/HiveServer.java a2d599f
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2a52fd1
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
ffce4fe
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
cd533b6
Diff: https://reviews.apache.org/r/2833/diff
Testing
-------
previous tests passed
Thanks,
iryoung
> Add configuration properties for HiveServer and HiveMetaStore port numbers
> --------------------------------------------------------------------------
>
> Key: HIVE-2489
> URL: https://issues.apache.org/jira/browse/HIVE-2489
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Metastore
> Reporter: Carl Steinbach
> Attachments: HIVE-2489.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
