----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52283/ -----------------------------------------------------------
(Updated Oct. 14, 2016, 6:32 p.m.) Review request for hive, Mohit Sabharwal and Sergio Pena. Changes ------- Added review suggestions and renamed the job credential property to hive.server2.job.credential.provider.path so that it is more in line with hadoop credential provider path property name. Created a sub-task HIVE-14962 to add integration tests in a separate change. Bugs: HIVE-14822 https://issues.apache.org/jira/browse/HIVE-14822 Repository: hive-git Description ------- This change adds support for credential provider for jobs launched from HiveServer2. It also adds support for job-specific credential provider and password which is passed to the jobs via the job configs when they are launched from HS2. The hive specific credential provider location is specified by a new configuration property specific to hiveserver2 and the password to job credential provider is provided using the environment variable Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/common/FileUtils.java 3ed2d086fd8e14b9a70550c02082c1456f905a08 common/src/java/org/apache/hadoop/hive/conf/Constants.java 77c6aa5663c2c5358715801bc039c0fe8035e3dc common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 18b98e9f28d363611da9b150ed9480cf350220cf common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java 16c2eafdb6888ed62168dd00f76335fa2484753b common/src/java/org/apache/hive/common/util/HiveStringUtils.java 507e369bbbae55cf2e6006209558dbb9112cc684 ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java cea9582c8ccb0c79700ac7913735d4cdf52f0c7e ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveSparkClientFactory.java 784b9c9fa769eeb088e3a6408a0b29147a8b4086 ql/src/java/org/apache/hadoop/hive/ql/exec/spark/LocalHiveSparkClient.java c75333d7022f776aab184a4b804fd7ad7befac64 ql/src/java/org/apache/hadoop/hive/ql/exec/spark/RemoteHiveSparkClient.java a9f70c4100219c8929abd4e31b30d340e6ba98bd ql/src/test/org/apache/hadoop/hive/ql/exec/TestHiveCredentialProviders.java PRE-CREATION spark-client/src/main/java/org/apache/hive/spark/client/SparkClientImpl.java 936fdafdb37c461a7a5deb97cba72d4db54a49e1 Diff: https://reviews.apache.org/r/52283/diff/ Testing ------- Testing running multiple queries on S3 with keys stored in a credential provider Thanks, Vihang Karajgaonkar