----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52835/#review152574 -----------------------------------------------------------
beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java <https://reviews.apache.org/r/52835/#comment221630> Now the dry run will execute the scripts but without commit. So it will get the correct schema version like real run. Before this change dry run actually only lists the scripts it will execute. beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java (line 256) <https://reviews.apache.org/r/52835/#comment221627> Yeah. I thought about changing the error. But we are committing one script file at a time and you can continue to run from the failed script if one fails. So for a whole upgrade process, that could be still in half way (e.g., upgrade from 0.7 to 2.2, failed at 1.3. Then you can try to upgrade from 1.3 to 2.2). So I intentionally leave like this. beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java (line 365) <https://reviews.apache.org/r/52835/#comment221628> Yeah. Actually I will move to open the connection. beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java (line 365) <https://reviews.apache.org/r/52835/#comment221629> Yeah. Actually I will move to open the connection. - Aihua Xu On Oct. 13, 2016, 3:25 p.m., Aihua Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52835/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2016, 3:25 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-14926: Keep Schema in consistent state where schemaTool fails or succeeds > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/HiveSchemaHelper.java > 181f0d28243cb5f9c4a14fa142b6b94009d77ea4 > beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java > cd36ddf3860cf56c7d4a7eadcc5bbb173e93a860 > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java > 9c30ee7add2eda912ab0a27283d1c0f4c689baee > > Diff: https://reviews.apache.org/r/52835/diff/ > > > Testing > ------- > > > Thanks, > > Aihua Xu > >
