----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52283/#review150996 -----------------------------------------------------------
LGTM, only nits and a minor question. Thanks for the patch! common/src/java/org/apache/hadoop/hive/common/EnvironmentUtils.java (line 23) <https://reviews.apache.org/r/52283/#comment219098> nit: allows us instead of allows use ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java (line 49) <https://reviews.apache.org/r/52283/#comment219101> Is JobConf used in this class? I can only see the import in the diff. ql/src/test/org/apache/hadoop/hive/ql/exec/TestHiveCredentialProviders.java (line 72) <https://reviews.apache.org/r/52283/#comment219102> nit: Can the common initialization be put into an init method annotated with @Before? ql/src/test/org/apache/hadoop/hive/ql/exec/TestHiveCredentialProviders.java (line 148) <https://reviews.apache.org/r/52283/#comment219103> nit: Can we have more meaningful test names than testUpdateCredentialProviders_xx? - Barna Zsombor Klara On Sept. 30, 2016, 12:45 a.m., Vihang Karajgaonkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52283/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2016, 12:45 a.m.) > > > Review request for hive, Mohit Sabharwal and Sergio Pena. > > > Bugs: HIVE-14822 > https://issues.apache.org/jira/browse/HIVE-14822 > > > Repository: hive-git > > > Description > ------- > > This change adds support for credential provider for jobs launched from > HiveServer2. It also adds support for job-specific credential provider and > password which is passed to the jobs via the job configs when they are > launched from HS2. The hive specific credential provider location is > specified by a new configuration property specific to hiveserver2 and the > password to job credential provider is provided using the environment variable > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/EnvironmentUtils.java > PRE-CREATION > common/src/java/org/apache/hadoop/hive/common/FileUtils.java > 3ed2d086fd8e14b9a70550c02082c1456f905a08 > common/src/java/org/apache/hadoop/hive/conf/Constants.java > 77c6aa5663c2c5358715801bc039c0fe8035e3dc > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > 43a16d7fed1d38400793e7c96a7febebe42d351b > common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java > 16c2eafdb6888ed62168dd00f76335fa2484753b > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java > fd640567124e1bb8b558359732764a07c8b0f2ed > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java > cea9582c8ccb0c79700ac7913735d4cdf52f0c7e > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java > ce1106d91db9ef75e7b425d5950f888bacbfb3e5 > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveSparkClientFactory.java > 784b9c9fa769eeb088e3a6408a0b29147a8b4086 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/LocalHiveSparkClient.java > c75333d7022f776aab184a4b804fd7ad7befac64 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/RemoteHiveSparkClient.java > a9f70c4100219c8929abd4e31b30d340e6ba98bd > ql/src/test/org/apache/hadoop/hive/ql/exec/TestHiveCredentialProviders.java > PRE-CREATION > > spark-client/src/main/java/org/apache/hive/spark/client/SparkClientImpl.java > 936fdafdb37c461a7a5deb97cba72d4db54a49e1 > > Diff: https://reviews.apache.org/r/52283/diff/ > > > Testing > ------- > > Testing running multiple queries on S3 with keys stored in a credential > provider > > > Thanks, > > Vihang Karajgaonkar > >
