----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52171/#review150102 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java (line 153) <https://reviews.apache.org/r/52171/#comment217952> is isNative just coming from the resistry? I wonder why these two methods exist - you can either choose a type, or not choose a type, for the same registry? ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java (line 498) <https://reviews.apache.org/r/52171/#comment217955> why shouldn't the just be in one? - Sergey Shelukhin On Sept. 22, 2016, 7:21 p.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52171/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2016, 7:21 p.m.) > > > Review request for hive and Sergey Shelukhin. > > > Bugs: HIVE-14819 > https://issues.apache.org/jira/browse/HIVE-14819 > > > Repository: hive-git > > > Description > ------- > > Patch to allow the registry to set PERSISTENT type when registering permanent > functions to the session registry. Previously all functions added to session > registry had the TEMPORARY tag > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionInfo.java 30ba996 > ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java 05926b5 > ql/src/java/org/apache/hadoop/hive/ql/exec/WindowFunctionInfo.java a16d9e5 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java > 911b86b > ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionRegistry.java > d2d5a1b > > Diff: https://reviews.apache.org/r/52171/diff/ > > > Testing > ------- > > Added tests to TestFunctionRegistry > > > Thanks, > > Jason Dere > >
