-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51699/#review148911
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/parse/MapReduceCompiler.java (line 90)
<https://reviews.apache.org/r/51699/#comment216422>

    Should we set the original value back once the compilation has finished?
    Can it cause any issues if recursive input dirs is set?


- Barna Zsombor Klara


On Sept. 7, 2016, 6:57 p.m., Chaoyu Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51699/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2016, 6:57 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-12812
>     https://issues.apache.org/jira/browse/HIVE-12812
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> mapred.input.dir.recursive itself is not Hive property, and it is often 
> ignored when user runs some queries (e.g. union) which needs it to be enabled 
> to process some intermediate data files. This patch is to enable this 
> property by default. Change only happens for MR since Tez has done similar in 
> its TezComplier and Spark does not need it.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/MapReduceCompiler.java 5b08ed2 
>   ql/src/test/queries/clientnegative/truncate_column_list_bucketing.q 90f6cf7 
>   ql/src/test/queries/clientpositive/infer_bucket_sort_list_bucket.q 64dd05d 
>   ql/src/test/queries/clientpositive/lb_fs_stats.q 5ad3ff3 
>   ql/src/test/queries/clientpositive/list_bucket_dml_1.q e38930f 
>   ql/src/test/queries/clientpositive/list_bucket_dml_10.q f25c174 
>   ql/src/test/queries/clientpositive/list_bucket_dml_11.q 8ac1627 
>   ql/src/test/queries/clientpositive/list_bucket_dml_12.q 9facfa5 
>   ql/src/test/queries/clientpositive/list_bucket_dml_13.q 0fe7f61 
>   ql/src/test/queries/clientpositive/list_bucket_dml_14.q abe5ea7 
>   ql/src/test/queries/clientpositive/list_bucket_dml_2.q c6dceab 
>   ql/src/test/queries/clientpositive/list_bucket_dml_3.q ef01529 
>   ql/src/test/queries/clientpositive/list_bucket_dml_4.q 950409d 
>   ql/src/test/queries/clientpositive/list_bucket_dml_5.q fce8e2e 
>   ql/src/test/queries/clientpositive/list_bucket_dml_6.q 631c938 
>   ql/src/test/queries/clientpositive/list_bucket_dml_7.q e2af1b3 
>   ql/src/test/queries/clientpositive/list_bucket_dml_8.q 6d73896 
>   ql/src/test/queries/clientpositive/list_bucket_dml_9.q d2e24af 
>   ql/src/test/queries/clientpositive/list_bucket_query_multiskew_1.q 1a4fbc2 
>   ql/src/test/queries/clientpositive/list_bucket_query_multiskew_2.q 996dce6 
>   ql/src/test/queries/clientpositive/list_bucket_query_multiskew_3.q f09026f 
>   ql/src/test/queries/clientpositive/list_bucket_query_oneskew_1.q cc597dc 
>   ql/src/test/queries/clientpositive/list_bucket_query_oneskew_2.q fb4cf6d 
>   ql/src/test/queries/clientpositive/list_bucket_query_oneskew_3.q 702de64 
>   ql/src/test/queries/clientpositive/recursive_dir.q d703b8e 
>   ql/src/test/queries/clientpositive/skewjoin_union_remove_1.q 5e688d7 
>   ql/src/test/queries/clientpositive/skewjoin_union_remove_2.q 3e2610f 
>   ql/src/test/queries/clientpositive/truncate_column_list_bucket.q 476120a 
>   ql/src/test/queries/clientpositive/union_remove_1.q 0a69068 
>   ql/src/test/queries/clientpositive/union_remove_10.q 7892e15 
>   ql/src/test/queries/clientpositive/union_remove_11.q fd41648 
>   ql/src/test/queries/clientpositive/union_remove_12.q b665666 
>   ql/src/test/queries/clientpositive/union_remove_13.q 11077fd 
>   ql/src/test/queries/clientpositive/union_remove_14.q b559b35 
>   ql/src/test/queries/clientpositive/union_remove_15.q 43c7834 
>   ql/src/test/queries/clientpositive/union_remove_16.q eca8aeb 
>   ql/src/test/queries/clientpositive/union_remove_17.q 59a3a9c 
>   ql/src/test/queries/clientpositive/union_remove_18.q 98ee7d0 
>   ql/src/test/queries/clientpositive/union_remove_19.q 9e47254 
>   ql/src/test/queries/clientpositive/union_remove_2.q 2ebc1ad 
>   ql/src/test/queries/clientpositive/union_remove_20.q 700ee4d 
>   ql/src/test/queries/clientpositive/union_remove_21.q 1b1472e 
>   ql/src/test/queries/clientpositive/union_remove_22.q d4d3cbc 
>   ql/src/test/queries/clientpositive/union_remove_23.q 98ae503 
>   ql/src/test/queries/clientpositive/union_remove_24.q 7ed80d1 
>   ql/src/test/queries/clientpositive/union_remove_25.q 78fa9aa 
>   ql/src/test/queries/clientpositive/union_remove_26.q 4e77d73 
>   ql/src/test/queries/clientpositive/union_remove_3.q b0f63fc 
>   ql/src/test/queries/clientpositive/union_remove_4.q 9ee6282 
>   ql/src/test/queries/clientpositive/union_remove_5.q 5d3c482 
>   ql/src/test/queries/clientpositive/union_remove_6.q 23eb760 
>   ql/src/test/queries/clientpositive/union_remove_6_subq.q 3607a52 
>   ql/src/test/queries/clientpositive/union_remove_7.q 5e0d14b 
>   ql/src/test/queries/clientpositive/union_remove_8.q 1e049ba 
>   ql/src/test/queries/clientpositive/union_remove_9.q b819560 
> 
> Diff: https://reviews.apache.org/r/51699/diff/
> 
> 
> Testing
> -------
> 
> Manual tests
> Precommit tests
> 
> 
> Thanks,
> 
> Chaoyu Tang
> 
>

Reply via email to