----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51694/ -----------------------------------------------------------
Review request for hive, Ashutosh Chauhan, Chaoyu Tang, Naveen Gangam, and Szehon Ho. Repository: hive-git Description ------- Currently LdapAuthenticationProviderImpl class is not covered with unit tests. To make this class testable some minor refactoring will be required. Diffs ----- service/pom.xml ecea719 service/src/java/org/apache/hive/service/auth/LdapAuthenticationProviderImpl.java efd5393 service/src/java/org/apache/hive/service/auth/ldap/ChainFilterFactory.java PRE-CREATION service/src/java/org/apache/hive/service/auth/ldap/CustomQueryFilterFactory.java PRE-CREATION service/src/java/org/apache/hive/service/auth/ldap/DirSearch.java PRE-CREATION service/src/java/org/apache/hive/service/auth/ldap/DirSearchFactory.java PRE-CREATION service/src/java/org/apache/hive/service/auth/ldap/Filter.java PRE-CREATION service/src/java/org/apache/hive/service/auth/ldap/FilterFactory.java PRE-CREATION service/src/java/org/apache/hive/service/auth/ldap/GroupFilterFactory.java PRE-CREATION service/src/java/org/apache/hive/service/auth/ldap/LdapSearch.java PRE-CREATION service/src/java/org/apache/hive/service/auth/ldap/LdapSearchFactory.java PRE-CREATION service/src/java/org/apache/hive/service/auth/ldap/LdapUtils.java PRE-CREATION service/src/java/org/apache/hive/service/auth/ldap/Query.java PRE-CREATION service/src/java/org/apache/hive/service/auth/ldap/QueryFactory.java PRE-CREATION service/src/java/org/apache/hive/service/auth/ldap/SearchResultHandler.java PRE-CREATION service/src/java/org/apache/hive/service/auth/ldap/UserFilterFactory.java PRE-CREATION service/src/java/org/apache/hive/service/auth/ldap/UserSearchFilterFactory.java PRE-CREATION service/src/test/org/apache/hive/service/auth/TestLdapAtnProviderWithMiniDS.java 089a059 service/src/test/org/apache/hive/service/auth/TestLdapAuthenticationProviderImpl.java f276906 service/src/test/org/apache/hive/service/auth/ldap/Credentials.java PRE-CREATION service/src/test/org/apache/hive/service/auth/ldap/LdapTestUtils.java PRE-CREATION service/src/test/org/apache/hive/service/auth/ldap/TestChainFilter.java PRE-CREATION service/src/test/org/apache/hive/service/auth/ldap/TestCustomQueryFilter.java PRE-CREATION service/src/test/org/apache/hive/service/auth/ldap/TestGroupFilter.java PRE-CREATION service/src/test/org/apache/hive/service/auth/ldap/TestLdapSearch.java PRE-CREATION service/src/test/org/apache/hive/service/auth/ldap/TestLdapUtils.java PRE-CREATION service/src/test/org/apache/hive/service/auth/ldap/TestQuery.java PRE-CREATION service/src/test/org/apache/hive/service/auth/ldap/TestQueryFactory.java PRE-CREATION service/src/test/org/apache/hive/service/auth/ldap/TestSearchResultHandler.java PRE-CREATION service/src/test/org/apache/hive/service/auth/ldap/TestUserFilter.java PRE-CREATION service/src/test/org/apache/hive/service/auth/ldap/TestUserSearchFilter.java PRE-CREATION Diff: https://reviews.apache.org/r/51694/diff/ Testing ------- ...hive/service> mvn clean test ... Results : Tests run: 123, Failures: 0, Errors: 0, Skipped: 0 [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 04:18 min [INFO] Finished at: 2016-09-06T08:46:04-07:00 [INFO] Final Memory: 66M/984M [INFO] ------------------------------------------------------------------------ Thanks, Illya Yalovyy
